From 86acc04d2874fb9ef00408a4b96d496030a95eb1 Mon Sep 17 00:00:00 2001 From: Anna Karas Date: Tue, 7 Jul 2020 15:34:54 +0200 Subject: [PATCH] tests: Improve test_skip_atoi() in /lib/string-test test case Confirm that the pointer is updated to point behind the parsed number. Signed-off-by: Anna Karas Change-Id: If75a51056229904612c6a9ea20db4182d1935009 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43288 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner Reviewed-by: Angel Pons --- tests/lib/string-test.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/lib/string-test.c b/tests/lib/string-test.c index 859f749618..7718547c70 100644 --- a/tests/lib/string-test.c +++ b/tests/lib/string-test.c @@ -48,11 +48,12 @@ struct str_with_l_val_t { struct str_with_u_val_t { char *str; uint32_t value; + uint32_t offset; } str_with_u_val[] = { - {"42aa", 42}, - {"a", 0}, - {"0", 0}, - {"4a2", 4}, + {"42aa", 42, 2}, + {"a", 0, 0}, + {"0", 0, 1}, + {"4a2", 4, 1}, }; static void test_strdup(void **state) @@ -207,11 +208,13 @@ static void test_strncmp(void **state) static void test_skip_atoi(void **state) { int i; - char *ptr; + char *ptr, *copy; for (i = 0; i < ARRAY_SIZE(str_with_u_val); i++) { ptr = str_with_u_val[i].str; + copy = ptr; assert_true(str_with_u_val[i].value == skip_atoi(&ptr)); + assert_int_equal(str_with_u_val[i].offset, ptr - copy); } }