From 870f69e2214d98a29e623a48953f305326e5870a Mon Sep 17 00:00:00 2001 From: Tristan Corrick Date: Wed, 1 Aug 2018 23:50:02 +1200 Subject: [PATCH] Documentation/Makefile.sphinx: Be cautious when running `rm -rf` If BUILDDIR were an empty string, running `make clean` would result in running `rm -rf /*`. Omitting the trailing /* prevents this. With a valid BUILDDIR, the behaviour of `make clean` changes slightly in that BUILDDIR itself is removed. However, this is probably more in line with what one would expect from `make clean`. Change-Id: I51b52bb6e7fe73a07fed6291a4f1cc253f2bf319 Signed-off-by: Tristan Corrick Reviewed-on: https://review.coreboot.org/27775 Reviewed-by: Angel Pons Reviewed-by: Patrick Georgi Reviewed-by: Stefan Tauner Tested-by: build bot (Jenkins) --- Documentation/Makefile.sphinx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx index 0ecebbe11e..2357f186cf 100644 --- a/Documentation/Makefile.sphinx +++ b/Documentation/Makefile.sphinx @@ -46,7 +46,7 @@ help: .PHONY: clean clean: - rm -rf $(BUILDDIR)/* + rm -rf $(BUILDDIR) .PHONY: html html: