GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests/memrange-test: Correct commentary on test_memrange_steal() 

Currently, memranges_steal() steals at the lowest possible address.
This is actually reflected by the test code that checks if the *base*
of the READONLY_TAG range changes. Furthermore, the test ends with the
memranges restored, so revise the comment on the final state.

Change-Id: Idef71ce464280c6805145f229de9e8913ba850bc
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66606
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Jan Dabros <jsd@semihalf.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber 2022-08-10 21:48:01 +02:00 committed by Martin Roth
parent f26d7ea2e9
commit 875f7315f3
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/lib/memrange-test.c
View File

@ -461,7 +461,7 @@ static void test_memrange_holes(void **state)
* memory from region with READONLY_TAG. * memory from region with READONLY_TAG.
* *
* Example memory ranges (res_mock1) for test_memrange_steal. * Example memory ranges (res_mock1) for test_memrange_steal.
* Space marked with (/) is not covered by any region at the end of the test. * Space marked with (/) is stolen during the test.
* *
* +--------CACHEABLE_TAG--------+ <-0xE000 * +--------CACHEABLE_TAG--------+ <-0xE000
* | | * | |
@ -471,10 +471,10 @@ static void test_memrange_holes(void **state)
* *
* *
* *
* +--------READONLY_TAG---------+ <-0xFF0000 * +--------READONLY_TAG---------+ <-0xFF0000 <-stolen_base
* |/////////////////////////////| <-stolen_base + 0x4000
* | |
* | | * | |
* |/////////////////////////////| <-stolen_base
* |/////////////////////////////| <-stolen_base + 0x4000
* +-----------------------------+ <-0x1000000 * +-----------------------------+ <-0x1000000
* *
* *