GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fam14 DSDT: Also return for unrecognized UUID in _OSC 

Fixing warnings introduced by the following patches:
http://review.coreboot.org/#/c/2684/
http://review.coreboot.org/#/c/2739/
http://review.coreboot.org/#/c/2714/

These patches were meant to fix the dmesg warning about
the OSC method not granting control appropriately.  These
patches then introduced warnings during the coreboot build
process which were missed during the patch submission
process.  These warnings are below:

	Intel ACPI Component Architecture
	ASL Optimizing Compiler version 20100528 [Oct 15 2010]
	Copyright (c) 2000 - 2010 Intel Corporation
	Supports ACPI Specification Revision 4.0a

		dsdt.ramstage.asl  1143:    Method(_OSC,4)
		Warning  1088 -                       ^ Not all control paths return a value (_OSC)

		dsdt.ramstage.asl  1143:    Method(_OSC,4)
		Warning  1081 -                       ^ Reserved method must return a value (Buffer required for _OSC)

	ASL Input:  dsdt.ramstage.asl - 1724 lines, 34917 bytes, 889 keywords
	AML Output: dsdt.ramstage.aml - 10470 bytes, 409 named objects, 480 executable opcodes

	Compilation complete. 0 Errors, 2 Warnings, 0 Remarks, 494 Optimizations

This patch gives the following compilation status:

	Intel ACPI Component Architecture
	ASL Optimizing Compiler version 20100528 [Oct  1 2012]
	Copyright (c) 2000 - 2010 Intel Corporation
	Supports ACPI Specification Revision 4.0a

	ASL Input:  dsdt.ramstage.asl - 1732 lines, 33295 bytes, 941 keywords
	AML Output: dsdt.ramstage.aml - 10152 bytes, 406 named objects, 535 executable opcodes

	Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 432 Optimizations

The fix is simply adding an Else statement to the If which checks
for the proper UUID.  This way, all outcomes will return a full
control package.  This patch has no effect on the dmesg output.

Change-Id: I8fa246400310b26679ffa3aa278069d2e9507160
Signed-off-by: Mike Loptien <mike.loptien@se-eng.com>
Reviewed-on: http://review.coreboot.org/3052
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martin.roth@se-eng.com>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Mike Loptien 2013-04-04 16:05:11 -06:00 committed by Ronald G. Minnich
parent 17c05f23e2
commit 8764b0e1c0
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/southbridge/amd/cimx/sb800/acpi/fch.asl
View File

@ -22,11 +22,20 @@
/* Operating System Capabilities Method */
Method(_OSC,4)
{ /* Check for proper PCI/PCIe UUID */
{
// Create DWord-addressable fields from the Capabilities Buffer
CreateDWordField(Arg3,0,CDW1)
CreateDWordField(Arg3,4,CDW2)
CreateDWordField(Arg3,8,CDW3)
/* Check for proper PCI/PCIe UUID */
If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))
{
/* Let OS control everything */
Return (Arg3)
} Else {
Or(CDW1,4,CDW1) // Unrecognized UUID
Return(Arg3)
}
}