AMD f15tn, f16kb: Remove CDIT table and DMI table
On AMD Trinity and Kabini boards errors similar to the following are shown. ASSERTION FAILED: file 'src/mainboard/asrock/imb-a180/agesawrapper.c',line 431 DmiTable:100123f7, AcpiPstatein: 10010129,AcpiSrat:0,AcpiSlit:0, Mce:10010de9,Cmc:10010eab,Alib:1002111c, AcpiIvrs:0 in agesawrapper_amdinitlate agesawrapper_amdinitlate failed: 5 The reason is that on f16kb boards, the CDIT and DMI table are not created. On f15tn boards, only the DMI table is not created. Until the root cause is found, disable the table generation to remove the errors. Thanks to Wei Hu for debugging and reporting this issue on the list [1]. [1] http://www.coreboot.org/pipermail/coreboot/2013-November/076607.html CDIT table is not created Change-Id: I837e3c322bb5331a9b950a72397796a60642c3f3 Signed-off-by: WANG Siyuan <SiYuan.Wang@amd.com> Signed-off-by: WANG Siyuan <wangsiyuanbuaa@gmail.com> Reviewed-on: http://review.coreboot.org/4092 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
This commit is contained in:
parent
fe6bdd96d8
commit
87bdd86fe0
|
@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
|
||||||
AmdCreateStruct(&AmdParamStruct);
|
AmdCreateStruct(&AmdParamStruct);
|
||||||
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
||||||
Status = AmdInitLate(AmdLateParams);
|
Status = AmdInitLate(AmdLateParams);
|
||||||
/* CDIT table is not created. */
|
|
||||||
if (Status != AGESA_SUCCESS) {
|
if (Status != AGESA_SUCCESS) {
|
||||||
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
||||||
ASSERT(Status == AGESA_SUCCESS);
|
ASSERT(Status == AGESA_SUCCESS);
|
||||||
|
|
|
@ -77,7 +77,8 @@
|
||||||
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_CRAT TRUE
|
#define BLDOPT_REMOVE_CRAT TRUE
|
||||||
//#define BLDOPT_REMOVE_DMI FALSE //TRUE
|
#define BLDOPT_REMOVE_CDIT TRUE
|
||||||
|
#define BLDOPT_REMOVE_DMI TRUE
|
||||||
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
||||||
|
|
|
@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
|
||||||
AmdCreateStruct(&AmdParamStruct);
|
AmdCreateStruct(&AmdParamStruct);
|
||||||
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
||||||
Status = AmdInitLate(AmdLateParams);
|
Status = AmdInitLate(AmdLateParams);
|
||||||
/* CDIT table is not created. */
|
|
||||||
if (Status != AGESA_SUCCESS) {
|
if (Status != AGESA_SUCCESS) {
|
||||||
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
||||||
ASSERT(Status == AGESA_SUCCESS);
|
ASSERT(Status == AGESA_SUCCESS);
|
||||||
|
|
|
@ -74,7 +74,7 @@
|
||||||
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_CRAT TRUE
|
#define BLDOPT_REMOVE_CRAT TRUE
|
||||||
//#define BLDOPT_REMOVE_DMI FALSE //TRUE
|
#define BLDOPT_REMOVE_DMI TRUE
|
||||||
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
||||||
|
|
|
@ -425,7 +425,6 @@ agesawrapper_amdinitlate (
|
||||||
AmdCreateStruct(&AmdParamStruct);
|
AmdCreateStruct(&AmdParamStruct);
|
||||||
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
||||||
Status = AmdInitLate(AmdLateParams);
|
Status = AmdInitLate(AmdLateParams);
|
||||||
/* CDIT table is not created. */
|
|
||||||
if (Status != AGESA_SUCCESS) {
|
if (Status != AGESA_SUCCESS) {
|
||||||
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
||||||
ASSERT(Status == AGESA_SUCCESS);
|
ASSERT(Status == AGESA_SUCCESS);
|
||||||
|
|
|
@ -74,7 +74,7 @@
|
||||||
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_CRAT TRUE
|
#define BLDOPT_REMOVE_CRAT TRUE
|
||||||
//#define BLDOPT_REMOVE_DMI FALSE //TRUE
|
#define BLDOPT_REMOVE_DMI TRUE
|
||||||
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
||||||
|
|
|
@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
|
||||||
AmdCreateStruct(&AmdParamStruct);
|
AmdCreateStruct(&AmdParamStruct);
|
||||||
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
||||||
Status = AmdInitLate(AmdLateParams);
|
Status = AmdInitLate(AmdLateParams);
|
||||||
/* CDIT table is not created. */
|
|
||||||
if (Status != AGESA_SUCCESS) {
|
if (Status != AGESA_SUCCESS) {
|
||||||
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
||||||
ASSERT(Status == AGESA_SUCCESS);
|
ASSERT(Status == AGESA_SUCCESS);
|
||||||
|
|
|
@ -77,7 +77,8 @@
|
||||||
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_CRAT TRUE
|
#define BLDOPT_REMOVE_CRAT TRUE
|
||||||
//#define BLDOPT_REMOVE_DMI FALSE //TRUE
|
#define BLDOPT_REMOVE_CDIT TRUE
|
||||||
|
#define BLDOPT_REMOVE_DMI TRUE
|
||||||
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
||||||
|
|
|
@ -427,7 +427,6 @@ agesawrapper_amdinitlate (
|
||||||
AmdCreateStruct(&AmdParamStruct);
|
AmdCreateStruct(&AmdParamStruct);
|
||||||
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr;
|
||||||
Status = AmdInitLate(AmdLateParams);
|
Status = AmdInitLate(AmdLateParams);
|
||||||
/* CDIT table is not created. */
|
|
||||||
if (Status != AGESA_SUCCESS) {
|
if (Status != AGESA_SUCCESS) {
|
||||||
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus);
|
||||||
ASSERT(Status == AGESA_SUCCESS);
|
ASSERT(Status == AGESA_SUCCESS);
|
||||||
|
|
|
@ -75,7 +75,7 @@
|
||||||
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
#define BLDOPT_REMOVE_SLIT FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
#define BLDOPT_REMOVE_WHEA FALSE //TRUE
|
||||||
#define BLDOPT_REMOVE_CRAT TRUE
|
#define BLDOPT_REMOVE_CRAT TRUE
|
||||||
//#define BLDOPT_REMOVE_DMI FALSE //TRUE
|
#define BLDOPT_REMOVE_DMI TRUE
|
||||||
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
//#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE
|
||||||
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
//#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE
|
||||||
|
|
Loading…
Reference in New Issue