soc/intel/quark: Drop BOOTBLOCK_SAVE_BIST_AND_TIMESTAMP
This was empty stub call doing nothing, to avoid targeting non-existing MMX registers. Change-Id: I78b83e6724159ea1eb0f8a0cf9d5b7ddfc9877b7 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/30390 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
parent
3534c1e42d
commit
87efe24cce
|
@ -44,23 +44,14 @@ debug_spinloop:
|
|||
|
||||
bootblock_protected_mode_entry:
|
||||
|
||||
#if !IS_ENABLED(CONFIG_USE_MARCH_586)
|
||||
/* MMX registers required here */
|
||||
|
||||
/* BIST result in eax */
|
||||
movl %eax, %ebx
|
||||
|
||||
/* Get an early timestamp */
|
||||
rdtsc
|
||||
|
||||
#if IS_ENABLED(CONFIG_BOOTBLOCK_SAVE_BIST_AND_TIMESTAMP)
|
||||
lea 1f, %ebp
|
||||
|
||||
/* eax: Low 32-bits of timestamp
|
||||
* ebx: BIST result
|
||||
* ebp: return address
|
||||
* edx: High 32-bits of timestamp
|
||||
*/
|
||||
jmp bootblock_save_bist_and_timestamp
|
||||
1:
|
||||
#else
|
||||
movd %ebx, %mm0
|
||||
movd %eax, %mm1
|
||||
movd %edx, %mm2
|
||||
|
|
|
@ -26,7 +26,6 @@ config CPU_SPECIFIC_OPTIONS
|
|||
select ARCH_RAMSTAGE_X86_32
|
||||
select ARCH_ROMSTAGE_X86_32
|
||||
select ARCH_VERSTAGE_X86_32
|
||||
select BOOTBLOCK_SAVE_BIST_AND_TIMESTAMP
|
||||
select C_ENVIRONMENT_BOOTBLOCK
|
||||
select HAVE_MONOTONIC_TIMER
|
||||
select NO_MMCONF_SUPPORT
|
||||
|
|
|
@ -99,28 +99,13 @@
|
|||
.equ CFGNONSTICKY_W1_OFFSET, (0x52)
|
||||
.equ FORCE_WARM_RESET, (0x00000001)
|
||||
|
||||
.global bootblock_save_bist_and_timestamp
|
||||
|
||||
bootblock_save_bist_and_timestamp:
|
||||
|
||||
/* eax: Low 32-bits of timestamp
|
||||
* ebx: BIST result
|
||||
* ebp: return address
|
||||
* edx: High 32-bits of timestamp
|
||||
*/
|
||||
|
||||
/* No values to save since Quark does not generate a BIST value
|
||||
* and the timestamp is not saved since future expansion in
|
||||
* bootblock_crt0.S could use ebp and edi. This code prevents
|
||||
* the use of the MMx registers by the default implementation.
|
||||
*/
|
||||
jmp *%ebp
|
||||
|
||||
.global bootblock_pre_c_entry
|
||||
|
||||
bootblock_pre_c_entry:
|
||||
|
||||
/* Get the timestamp since value from bootblock_crt0.S was discarded */
|
||||
/* Get the timestamp since code in bootblock_crt0.S requires
|
||||
* MMX register support.
|
||||
*/
|
||||
rdtsc
|
||||
movl %eax, %ebp
|
||||
movl %edx, %edi
|
||||
|
|
Loading…
Reference in New Issue