GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard/google/kahlee: Fix GPIO table 

The GPIOs that are being set low had the wrong value getting set.
FCH_GPIO_OUTPUT_VALUE was being set instead of FCH_GPIO_OUTPUT_ENABLE.

BUG=b:70234300
TEST=Build and boot Grunt

Change-Id: I16792b76252506a43aac92738b04096ae3fde01c
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/23224
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
This commit is contained in:
Martin Roth 2018-01-11 14:12:58 -08:00
parent c40d690b78
commit 883de54fed
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/kahlee/variants/baseboard/gpio.c
View File

@ -112,7 +112,7 @@ static const GPIO_CONTROL agesa_board_gpios[] = {
{ GPIO_42, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },
/* GPIO_67 - PEN_RESET */
{ GPIO_67, Function0, FCH_GPIO_OUTPUT_VALUE },
{ GPIO_67, Function0, FCH_GPIO_OUTPUT_ENABLE },
/* GPIO_70 - WLAN_PE_RST_L */
{ GPIO_70, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },
@ -127,10 +127,10 @@ static const GPIO_CONTROL agesa_board_gpios[] = {
{ GPIO_76, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },
/* GPIO_84 - HUB_RST (Active High) */
{ GPIO_84, Function1, FCH_GPIO_OUTPUT_VALUE },
{ GPIO_84, Function1, FCH_GPIO_OUTPUT_ENABLE },
/* GPIO_85 - TOUCHSCREEN_RST (Active High) */
{ GPIO_85, Function1, FCH_GPIO_OUTPUT_VALUE },
{ GPIO_85, Function1, FCH_GPIO_OUTPUT_ENABLE },
/* GPIO_86 - Unused (TP109) */
{ GPIO_86, Function1, FCH_GPIO_PULL_UP_ENABLE },
@ -208,7 +208,7 @@ static const GPIO_CONTROL agesa_board_gpios[] = {
{ GPIO_132, Function2, },
/* GPIO_133 - APU_EDP_BKLTEN_L (backlight - Active LOW) */
{ GPIO_133, Function1, FCH_GPIO_OUTPUT_VALUE },
{ GPIO_133, Function1, FCH_GPIO_OUTPUT_ENABLE },
/* GPIO_135 - Unused (TP128) */
{ GPIO_135, Function1, FCH_GPIO_PULL_UP_ENABLE },