From 887b779c11363b5e9b9be0d2260598fa12a92c43 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 23 Jun 2021 14:16:10 +0200 Subject: [PATCH] Broadwell boards: Do not assign unused SPD addresses The `pei_data` struct is already zero-initialised. Change-Id: If539cddc007f32a04389bc3b3b06c43cb5c86e10 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/55804 Reviewed-by: Matt DeVillier Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/mainboard/google/auron/variants/buddy/spd/spd.c | 2 -- src/mainboard/google/jecht/spd/spd.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/mainboard/google/auron/variants/buddy/spd/spd.c b/src/mainboard/google/auron/variants/buddy/spd/spd.c index 9a5480e2be..200d909538 100644 --- a/src/mainboard/google/auron/variants/buddy/spd/spd.c +++ b/src/mainboard/google/auron/variants/buddy/spd/spd.c @@ -7,9 +7,7 @@ void mainboard_fill_spd_data(struct pei_data *pei_data) { pei_data->spd_addresses[0] = 0xa0; - pei_data->spd_addresses[1] = 0x00; pei_data->spd_addresses[2] = 0xa4; - pei_data->spd_addresses[3] = 0x00; pei_data->dimm_channel0_disabled = 2; pei_data->dimm_channel1_disabled = 2; /* Enable 2x refresh mode */ diff --git a/src/mainboard/google/jecht/spd/spd.c b/src/mainboard/google/jecht/spd/spd.c index f4454b8fa5..102ba4933e 100644 --- a/src/mainboard/google/jecht/spd/spd.c +++ b/src/mainboard/google/jecht/spd/spd.c @@ -7,9 +7,7 @@ void mainboard_fill_spd_data(struct pei_data *pei_data) { pei_data->spd_addresses[0] = 0xa0; - pei_data->spd_addresses[1] = 0x00; pei_data->spd_addresses[2] = 0xa4; - pei_data->spd_addresses[3] = 0x00; pei_data->dimm_channel0_disabled = 2; pei_data->dimm_channel1_disabled = 2; // Enable 2x refresh mode