From 88a2e3b3bf7b622cd3bef941a3e3f71337644a39 Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Mon, 9 Jan 2017 17:40:21 -0600 Subject: [PATCH] amd/mct/ddr3: Fix unintended sign extension warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit An unintended sign extension warning was thrown by Coverity. Explicitly state the length of the constant multiplier. Found-by: Coverity Scan #1347342 Change-Id: Icd42eec13be04fc5fd2ffc85320cbadafc852148 Signed-off-by: Timothy Pearson Reviewed-on: https://review.coreboot.org/18077 Reviewed-by: Jonathan Neuschäfer Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Tested-by: Raptor Engineering Automated Test Stand --- src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index f726345f00..b64ad54711 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -2474,10 +2474,10 @@ static void set_up_cc6_storage_fam15(struct MCTStatStruc *pMCTstat, if (interleaved) /* Move upper limit down by 16M * the number of nodes */ - max_range_limit -= (0x1000000 * num_nodes); + max_range_limit -= (0x1000000ULL * num_nodes); else /* Move upper limit down by 16M */ - max_range_limit -= 0x1000000; + max_range_limit -= 0x1000000ULL; printk(BIOS_INFO, "%s:\tnew max_range_limit: %16llx\n", __func__, max_range_limit);