GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/acpi: Remove DMA addresses for UARTs 

This is not the correct way to specify the FixedDMA devices. I'm
removing for now since it adds confusion.

BUG=none
BRANCH=zork
TEST=Boot zork to linux and make sure UART still works

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I17b9c8dbe4f9c4b64ee1bd69cb9b30998e727632
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49843
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Raul E Rangel 2021-01-22 10:04:59 -07:00 committed by Felix Held
parent 613f9fc91f
commit 892a423de8
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/amd/picasso/acpi/sb_fch.asl
View File

@ -106,7 +106,6 @@ Device (FUR0)
Exclusive, , , IRQR) Exclusive, , , IRQR)
{ 0 } { 0 }
Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000)
} }
CreateDWordField (Local0, IRQR._INT, IRQN) CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) { If (PICM) {
@ -117,7 +116,6 @@ Device (FUR0)
If (IRQN == 0x1f) { If (IRQN == 0x1f) {
Return (ResourceTemplate() { Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000)
}) })
} Else { } Else {
Return (Local0) Return (Local0)
@ -139,7 +137,6 @@ Device (FUR1) {
Exclusive, , , IRQR) Exclusive, , , IRQR)
{ 0 } { 0 }
Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000)
} }
CreateDWordField (Local0, IRQR._INT, IRQN) CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) { If (PICM) {
@ -150,7 +147,6 @@ Device (FUR1) {
If (IRQN == 0x1f) { If (IRQN == 0x1f) {
Return (ResourceTemplate() { Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000)
}) })
} Else { } Else {
Return (Local0) Return (Local0)
@ -172,7 +168,6 @@ Device (FUR2) {
Exclusive, , , IRQR) Exclusive, , , IRQR)
{ 0 } { 0 }
Memory32Fixed (ReadWrite, APU_UART2_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART2_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC2_BASE, 0x1000)
} }
CreateDWordField (Local0, IRQR._INT, IRQN) CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) { If (PICM) {
@ -183,7 +178,6 @@ Device (FUR2) {
If (IRQN == 0x1f) { If (IRQN == 0x1f) {
Return (ResourceTemplate() { Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART2_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART2_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC2_BASE, 0x1000)
}) })
} Else { } Else {
Return (Local0) Return (Local0)
@ -205,7 +199,6 @@ Device (FUR3) {
Exclusive, , , IRQR) Exclusive, , , IRQR)
{ 0 } { 0 }
Memory32Fixed (ReadWrite, APU_UART3_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART3_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC3_BASE, 0x1000)
} }
CreateDWordField (Local0, IRQR._INT, IRQN) CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) { If (PICM) {
@ -216,7 +209,6 @@ Device (FUR3) {
If (IRQN == 0x1f) { If (IRQN == 0x1f) {
Return (ResourceTemplate() { Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART3_BASE, 0x1000) Memory32Fixed (ReadWrite, APU_UART3_BASE, 0x1000)
Memory32Fixed (ReadWrite, APU_DMAC3_BASE, 0x1000)
}) })
} Else { } Else {
Return (Local0) Return (Local0)