GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/bd82x6x: assign PCH PCI bridge ops in chipset devicetree 

Since the PCI bridge in the PCH is always on the same device function,
the device operations can be statically assigned in the devicetree and
there's no need to bind the PCI bridge device operations to the PCI
device during runtime via a list of PCI IDs.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ic9ca925a12e64c9a5b3bf295653bf032572ff29a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79169
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Felix Held 2023-11-18 17:49:48 +01:00
parent 1bb327f216
commit 898757fc44
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/northbridge/intel/sandybridge/chipset.cb
View File

@ -36,7 +36,7 @@ chip northbridge/intel/sandybridge
device pci 1c.6 alias pcie_rp7 off ops bd82x6x_pcie_rp_ops end # PCIe Port #7
device pci 1c.7 alias pcie_rp8 off ops bd82x6x_pcie_rp_ops end # PCIe Port #8
device pci 1d.0 alias ehci1 off end # USB2 EHCI #1
device pci 1e.0 alias pci_bridge off end # PCI bridge
device pci 1e.0 alias pci_bridge off ops bd82x6x_pci_bridge_ops end
device pci 1f.0 alias lpc on ops bd82x6x_lpc_bridge_ops end
device pci 1f.2 alias sata1 off end # SATA Controller 1
device pci 1f.3 alias smbus on ops bd82x6x_smbus_ops end

14
src/southbridge/intel/bd82x6x/pci.c
View File

@ -35,7 +35,7 @@ static void pci_init(struct device *dev)
pci_write_config16(dev, SECSTS, reg16);
}
static struct device_operations device_ops = {
struct device_operations bd82x6x_pci_bridge_ops = {
.read_resources = pci_bus_read_resources,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_bus_enable_resources,
@ -43,15 +43,3 @@ static struct device_operations device_ops = {
.scan_bus = pci_scan_bridge,
.ops_pci = &pci_dev_ops_pci,
};
static const unsigned short pci_device_ids[] = {
0x2448, /* Mobile */
0x244e, /* Desktop */
0
};
static const struct pci_driver pch_pci __pci_driver = {
.ops = &device_ops,
.vendor = PCI_VID_INTEL,
.devices = pci_device_ids,
};