GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/net/r8168: Demote MAC lookup printk from error to warn 

Some older devices use the vpd key 'ethernet_mac' vs 'ethernet_mac0'
for the first/only LAN NIC, so don't treat the key lookup as an error.
If no MAC is able to be found, another error will be printed later
in the driver init.

TEST=build/boot google/fizz, dump cbmem log, verify 'ethernet_mac0'
lookup failure printk output at warning level.

Change-Id: If5226f4686a819a7020fd14f130181420ee1462b
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72475
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Matt DeVillier 2023-01-26 14:37:44 -06:00 committed by Eric Lai
parent b3034ebae2
commit 8a1de83016
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/drivers/net/r8168.c
View File

@ -109,7 +109,7 @@ static enum cb_err fetch_mac_vpd_key(u8 *macstrbuf, const char *vpd_key)
search_length); search_length);
if (offset == search_length) { if (offset == search_length) {
printk(BIOS_ERR, "Could not locate '%s' in VPD\n", vpd_key); printk(BIOS_WARNING, "Could not locate '%s' in VPD\n", vpd_key);
rdev_munmap(&rdev, search_address); rdev_munmap(&rdev, search_address);
return CB_ERR; return CB_ERR;
} }