GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

edid: fill reserved bits fields in cb_framebuffer 

If it's a 4 byte format (as per documentation), there
are some reserved bits, so let's mark them as such...

Unfortunately undone while upstreaming changes.

Change-Id: I50f12cfff2c9bb9d082a5f3c3ac54c0d514d862c
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Originally-Reviewed-on: http://review.coreboot.org/7674
Reviewed-on: http://review.coreboot.org/7964
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Patrick Georgi 2014-12-06 17:35:25 +01:00 committed by Patrick Georgi
parent 63f6dc79db
commit 8b12a28116
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/edid.c
View File

@ -1456,10 +1456,14 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
* I'm not sure with grahpics you ever can. * I'm not sure with grahpics you ever can.
*/ */
edid_fb.bits_per_pixel = edid->framebuffer_bits_per_pixel; edid_fb.bits_per_pixel = edid->framebuffer_bits_per_pixel;
edid_fb.reserved_mask_pos = 0;
edid_fb.reserved_mask_size = 0;
switch(edid->framebuffer_bits_per_pixel){ switch(edid->framebuffer_bits_per_pixel){
case 32: case 32:
case 24: case 24:
/* packed into 4-byte words */ /* packed into 4-byte words */
edid_fb.reserved_mask_pos = 24;
edid_fb.reserved_mask_size = 8;
edid_fb.red_mask_pos = 16; edid_fb.red_mask_pos = 16;
edid_fb.red_mask_size = 8; edid_fb.red_mask_size = 8;
edid_fb.green_mask_pos = 8; edid_fb.green_mask_pos = 8;
@ -1482,8 +1486,6 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
return; return;
} }
edid_fb.reserved_mask_pos = 0;
edid_fb.reserved_mask_size = 0;
vbe_valid = 1; vbe_valid = 1;
} }