From 8b223d43ce5e00b08fe19bdb044344b4e98e7a22 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Fri, 17 Feb 2023 02:22:31 +0530 Subject: [PATCH] soc/intel/cmn/acpi/pep: Add PCI device number for warning msg MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes the wrong warning msg around `Unknown min d_state` with having proper PCI Bus/Device/Function number to help to parse the log better. With this patch: [WARN ]  Unknown min d_state for 20 [WARN ]  Unknown min d_state for 50 [WARN ]  Unknown min d_state for 98 [WARN ]  Unknown min d_state for 9a [WARN ]  Unknown min d_state for f9 With this patch: [WARN ]  Unknown min d_state for PCI: 00:04.0 [WARN ]  Unknown min d_state for PCI: 00:0a.0 [WARN ]  Unknown min d_state for PCI: 00:13.0 [WARN ]  Unknown min d_state for PCI: 00:13.2 [WARN ]  Unknown min d_state for PCI: 00:1f.1 Change-Id: Iccaf26882ce5998469b2be6cf5bc7082f193cb29 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/73071 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Ivy Jian Reviewed-by: Kapil Porwal --- src/soc/intel/common/block/acpi/pep.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/soc/intel/common/block/acpi/pep.c b/src/soc/intel/common/block/acpi/pep.c index 0ba38c11af..b3150198ba 100644 --- a/src/soc/intel/common/block/acpi/pep.c +++ b/src/soc/intel/common/block/acpi/pep.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -148,7 +149,8 @@ static enum acpi_device_sleep_states get_min_sleep_state( for (size_t i = 0; i < size; i++) if (states_arr[i].pci_dev == dev->path.pci.devfn) return states_arr[i].min_sleep_state; - printk(BIOS_WARNING, "Unknown min d_state for %x\n", dev->path.pci.devfn); + printk(BIOS_WARNING, "Unknown min d_state for PCI: 00:%02x.%01x\n", + PCI_SLOT(dev->path.pci.devfn), PCI_FUNC(dev->path.pci.devfn)); return ACPI_DEVICE_SLEEP_NONE; default: