GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

timestamps: Fix TIMESTAMPS_ON_CONSOLE behaviour 

As logging is guarded by Kconfig, increase the level from BIOS_SPEW
to BIOS_INFO.

The original callsite inside timestamp_add_table_entry() was also
called when syncing from timestamps from .bss to CBMEM. We should
not reprint the values then.

Change-Id: I72ca4b6a04d8734c141a04e651fc8c23932b1f23
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38300
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Kyösti Mälkki 2020-01-09 08:41:46 +02:00 committed by Nico Huber
parent 37bf996efb
commit 8b93cb756c
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Kconfig
View File

@ -224,7 +224,7 @@ config TIMESTAMPS_ON_CONSOLE
default n default n
depends on COLLECT_TIMESTAMPS depends on COLLECT_TIMESTAMPS
help help
Print the timestamps to the debug console if enabled at level spew. Print the timestamps to the debug console if enabled at level info.
config USE_BLOBS config USE_BLOBS
bool "Allow use of binary-only repository" bool "Allow use of binary-only repository"

6
src/lib/timestamp.c
View File

@ -130,9 +130,6 @@ static void timestamp_add_table_entry(struct timestamp_table *ts_table,
tse->entry_id = id; tse->entry_id = id;
tse->entry_stamp = ts_time - ts_table->base_time; tse->entry_stamp = ts_time - ts_table->base_time;
if (CONFIG(TIMESTAMPS_ON_CONSOLE))
printk(BIOS_SPEW, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time);
if (ts_table->num_entries == ts_table->max_entries) if (ts_table->num_entries == ts_table->max_entries)
printk(BIOS_ERR, "ERROR: Timestamp table full\n"); printk(BIOS_ERR, "ERROR: Timestamp table full\n");
} }
@ -152,6 +149,9 @@ void timestamp_add(enum timestamp_id id, uint64_t ts_time)
} }
timestamp_add_table_entry(ts_table, id, ts_time); timestamp_add_table_entry(ts_table, id, ts_time);
if (CONFIG(TIMESTAMPS_ON_CONSOLE))
printk(BIOS_INFO, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time);
} }
void timestamp_add_now(enum timestamp_id id) void timestamp_add_now(enum timestamp_id id)