GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode() 

The only path that leads here is guarded by both !DRIVERS_UART_
8250MEM_32 and INTEL_LPSS_UART_FOR_CONSOLE but the latter selects
the former.

Change-Id: I6e0765b028572950991c45b45b2051f4f176a94a
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33095
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lance Zhao <lance.zhao@gmail.com>
This commit is contained in:
Nico Huber 2019-05-29 23:18:26 +02:00 committed by Patrick Georgi
parent 51dc5ea735
commit 8bbad6c818
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/common/block/include/intelblocks/uart.h
View File

@ -91,10 +91,4 @@ struct device *uart_get_device(void);
*/ */
struct device *soc_uart_console_to_device(int uart_console); struct device *soc_uart_console_to_device(int uart_console);
/*
* Set UART to legacy mode
* Put UART in byte access mode for 16550 compatibility
*/
void soc_uart_set_legacy_mode(void);
#endif /* SOC_INTEL_COMMON_BLOCK_UART_H */ #endif /* SOC_INTEL_COMMON_BLOCK_UART_H */

4
src/soc/intel/common/block/uart/uart.c
View File

@ -139,10 +139,6 @@ void uart_bootblock_init(void)
uart_common_init(uart_get_device(), uart_common_init(uart_get_device(),
UART_BASE(CONFIG_UART_FOR_CONSOLE)); UART_BASE(CONFIG_UART_FOR_CONSOLE));
if (!CONFIG(DRIVERS_UART_8250MEM_32))
/* Put UART in byte access mode for 16550 compatibility */
soc_uart_set_legacy_mode();
/* Configure the 2 pads per UART. */ /* Configure the 2 pads per UART. */
uart_configure_gpio_pads(); uart_configure_gpio_pads();
} }