From 8be5b59a4105a1c783483856b6ed6917011dd484 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 22 Jul 2020 10:12:06 +0200 Subject: [PATCH] nb/intel/sandybridge: Remove unnecessary `struct sys_info` It was only used in one function, but its value was never read. Drop it. Change-Id: Ib511352d51d4452d666640d0f52810b06c8d61ce Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/43702 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph --- src/northbridge/intel/sandybridge/raminit.h | 3 --- src/northbridge/intel/sandybridge/raminit_mrc.c | 5 ----- 2 files changed, 8 deletions(-) diff --git a/src/northbridge/intel/sandybridge/raminit.h b/src/northbridge/intel/sandybridge/raminit.h index dc0134312f..c5d881a196 100644 --- a/src/northbridge/intel/sandybridge/raminit.h +++ b/src/northbridge/intel/sandybridge/raminit.h @@ -5,12 +5,9 @@ #include "pei_data.h" -struct sys_info { - u8 boot_path; #define BOOT_PATH_NORMAL 0 #define BOOT_PATH_RESET 1 #define BOOT_PATH_RESUME 2 -} __packed; void sdram_initialize(struct pei_data *pei_data); void save_mrc_data(struct pei_data *pei_data); diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index e1fe7c827b..cea32afa35 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -120,7 +120,6 @@ static void prepare_mrc_cache(struct pei_data *pei_data) */ void sdram_initialize(struct pei_data *pei_data) { - struct sys_info sysinfo; int (*entry)(struct pei_data *pei_data) __attribute__((regparm(1))); /* Wait for ME to be ready */ @@ -129,10 +128,6 @@ void sdram_initialize(struct pei_data *pei_data) printk(BIOS_DEBUG, "Starting UEFI PEI System Agent\n"); - memset(&sysinfo, 0, sizeof(sysinfo)); - - sysinfo.boot_path = pei_data->boot_mode; - /* * Do not pass MRC data in for recovery mode boot, * Always pass it in for S3 resume.