GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MPTABLE: check for fixed IRQ entries on all pins 

Don't derive the IRQ pin from the function number. Especially onboard
chipset devices don't follow that rule. Instead check and add all
fixed IRQ entries.

Change-Id: I46c88bad39104c1d9b4154f180f8b3c42df28262
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/1461
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
This commit is contained in:
Sven Schnelle 2012-08-20 11:19:00 +02:00 committed by Alexandru Gagniuc
parent 651339bb5d
commit 8c02790882
1 changed files with 44 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
src/arch/x86/boot/mpspec.c
View File

@ -419,7 +419,7 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr)
int isa_bus, pin, parentpin; int isa_bus, pin, parentpin;
device_t dev, parent, oldparent; device_t dev, parent, oldparent;
void *tmp, *v; void *tmp, *v;
int isaioapic = -1; int isaioapic = -1, have_fixed_entries;
v = smp_write_floating_table(addr, 0); v = smp_write_floating_table(addr, 0);
mc = (void *)(((char *)v) + SMP_FLOATING_TABLE_LEN); mc = (void *)(((char *)v) + SMP_FLOATING_TABLE_LEN);
@ -461,48 +461,53 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr)
if (dev->path.type != DEVICE_PATH_PCI || !dev->enabled) if (dev->path.type != DEVICE_PATH_PCI || !dev->enabled)
continue; continue;
pin = (dev->path.pci.devfn & 7) % 4; have_fixed_entries = 0;
for (pin = 0; pin < 4; pin++) {
if (dev->pci_irq_info[pin].ioapic_dst_id) {
printk(BIOS_DEBUG, "fixed IRQ entry for: %s: INT%c# -> IOAPIC %d PIN %d\n", dev_path(dev),
pin + 'A',
dev->pci_irq_info[pin].ioapic_dst_id,
dev->pci_irq_info[pin].ioapic_irq_pin);
smp_write_intsrc(mc, mp_INT,
dev->pci_irq_info[pin].ioapic_flags,
dev->bus->secondary,
((dev->path.pci.devfn & 0xf8) >> 1) | pin,
dev->pci_irq_info[pin].ioapic_dst_id,
dev->pci_irq_info[pin].ioapic_irq_pin);
have_fixed_entries = 1;
}
}
if (dev->pci_irq_info[pin].ioapic_dst_id) { if (!have_fixed_entries) {
printk(BIOS_DEBUG, "fixed IRQ entry for: %s: INT%c# -> IOAPIC %d PIN %d\n", dev_path(dev), pin = (dev->path.pci.devfn & 7) % 4;
pin + 'A', oldparent = parent = dev;
dev->pci_irq_info[pin].ioapic_dst_id, while((parent = parent->bus->dev)) {
dev->pci_irq_info[pin].ioapic_irq_pin); parentpin = (oldparent->path.pci.devfn >> 3) + (oldparent->path.pci.devfn & 7);
smp_write_intsrc(mc, mp_INT, parentpin += dev->path.pci.devfn & 7;
dev->pci_irq_info[pin].ioapic_flags, parentpin += dev->path.pci.devfn >> 3;
dev->bus->secondary, parentpin %= 4;
((dev->path.pci.devfn & 0xf8) >> 1) | pin,
dev->pci_irq_info[pin].ioapic_dst_id,
dev->pci_irq_info[pin].ioapic_irq_pin);
} else {
oldparent = parent = dev;
while((parent = parent->bus->dev)) {
parentpin = (oldparent->path.pci.devfn >> 3) + (oldparent->path.pci.devfn & 7);
parentpin += dev->path.pci.devfn & 7;
parentpin += dev->path.pci.devfn >> 3;
parentpin %= 4;
if (parent->pci_irq_info[parentpin].ioapic_dst_id) { if (parent->pci_irq_info[parentpin].ioapic_dst_id) {
printk(BIOS_DEBUG, "automatic IRQ entry for %s: INT%c# -> IOAPIC %d PIN %d\n", printk(BIOS_DEBUG, "automatic IRQ entry for %s: INT%c# -> IOAPIC %d PIN %d\n",
dev_path(dev), pin + 'A', dev_path(dev), pin + 'A',
parent->pci_irq_info[parentpin].ioapic_dst_id, parent->pci_irq_info[parentpin].ioapic_dst_id,
parent->pci_irq_info[parentpin].ioapic_irq_pin); parent->pci_irq_info[parentpin].ioapic_irq_pin);
smp_write_intsrc(mc, mp_INT, smp_write_intsrc(mc, mp_INT,
parent->pci_irq_info[parentpin].ioapic_flags, parent->pci_irq_info[parentpin].ioapic_flags,
dev->bus->secondary, dev->bus->secondary,
((dev->path.pci.devfn & 0xf8) >> 1) | pin, ((dev->path.pci.devfn & 0xf8) >> 1) | pin,
parent->pci_irq_info[parentpin].ioapic_dst_id, parent->pci_irq_info[parentpin].ioapic_dst_id,
parent->pci_irq_info[parentpin].ioapic_irq_pin); parent->pci_irq_info[parentpin].ioapic_irq_pin);
break; break;
}
if (parent->path.type == DEVICE_PATH_PCI_DOMAIN) {
printk(BIOS_WARNING, "no IRQ found for %s\n", dev_path(dev));
break;
}
oldparent = parent;
} }
if (parent->path.type == DEVICE_PATH_PCI_DOMAIN) {
printk(BIOS_WARNING, "no IRQ found for %s\n", dev_path(dev));
break;
}
oldparent = parent;
}
} }
} }