GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86,amd: drop unused LOGICAL_CPUS Kconfig symbol 

The LOGICAL_CPUS Kconfig option is always true and also not user-
configurable, so it can be dropped.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ie4866de003058ec0f99495b405e26dfd7ba1fa28
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73553
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
This commit is contained in:
Felix Held 2023-03-07 23:56:09 +01:00
parent 07a56e02bf
commit 8cbd216836
2 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/cpu/amd/pi/00730F01/model_16_init.c
View File

@ -25,20 +25,18 @@ static void model_16_init(struct device *dev)
/* zero the machine check error status registers */ /* zero the machine check error status registers */
mca_clear_status(); mca_clear_status();
if (CONFIG(LOGICAL_CPUS)) { siblings = get_cpu_count() - 1; // minus BSP
siblings = get_cpu_count() - 1; // minus BSP
if (siblings > 0) { if (siblings > 0) {
msr = rdmsr_amd(CPU_ID_FEATURES_MSR); msr = rdmsr_amd(CPU_ID_FEATURES_MSR);
msr.lo |= 1 << 28; msr.lo |= 1 << 28;
wrmsr_amd(CPU_ID_FEATURES_MSR, msr); wrmsr_amd(CPU_ID_FEATURES_MSR, msr);
msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR); msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR);
msr.hi |= 1 << (33 - 32); msr.hi |= 1 << (33 - 32);
wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr); wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr);
}
printk(BIOS_DEBUG, "siblings = %02d, ", siblings);
} }
printk(BIOS_DEBUG, "siblings = %02d, ", siblings);
/* DisableCf8ExtCfg */ /* DisableCf8ExtCfg */
msr = rdmsr(NB_CFG_MSR); msr = rdmsr(NB_CFG_MSR);

4
src/cpu/x86/Kconfig
View File

@ -126,10 +126,6 @@ config SETUP_XIP_CACHE
non-eviction mode and therefore need to be careful to avoid non-eviction mode and therefore need to be careful to avoid
eviction. eviction.
config LOGICAL_CPUS
bool
default y
config HAVE_SMI_HANDLER config HAVE_SMI_HANDLER
bool bool
default n default n