From 8d14633dfb21b6789814e1c3ca6700d4be7e50b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 15 Nov 2022 14:00:22 +0200 Subject: [PATCH] nb/intel/ironlake,sandybridge/gma: Fix out() parameter order MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I4baa2e06d336736caf5505a05ed4353bcbfdb517 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/69670 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Angel Pons Reviewed-by: Arthur Heymans Reviewed-by: Elyes Haouas --- src/northbridge/intel/ironlake/gma.c | 6 +++--- src/northbridge/intel/sandybridge/gma.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/northbridge/intel/ironlake/gma.c b/src/northbridge/intel/ironlake/gma.c index 8084560636..fb21d35b55 100644 --- a/src/northbridge/intel/ironlake/gma.c +++ b/src/northbridge/intel/ironlake/gma.c @@ -122,15 +122,15 @@ static void gma_enable_swsci(void) /* clear DMISCI status */ reg16 = inw(DEFAULT_PMBASE + TCO1_STS); reg16 &= DMISCI_STS; - outw(DEFAULT_PMBASE + TCO1_STS, reg16); + outw(reg16, DEFAULT_PMBASE + TCO1_STS); /* clear acpi tco status */ - outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS); + outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS); /* enable acpi tco scis */ reg16 = inw(DEFAULT_PMBASE + GPE0_EN); reg16 |= TCOSCI_EN; - outw(DEFAULT_PMBASE + GPE0_EN, reg16); + outw(reg16, DEFAULT_PMBASE + GPE0_EN); } static void gma_func0_init(struct device *dev) diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index d1b9263980..3eed5cc9bc 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -570,15 +570,15 @@ static void gma_enable_swsci(void) /* Clear DMISCI status */ reg16 = inw(DEFAULT_PMBASE + TCO1_STS); reg16 &= DMISCI_STS; - outw(DEFAULT_PMBASE + TCO1_STS, reg16); + outw(reg16, DEFAULT_PMBASE + TCO1_STS); /* Clear ACPI TCO status */ - outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS); + outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS); /* Enable ACPI TCO SCIs */ reg16 = inw(DEFAULT_PMBASE + GPE0_EN); reg16 |= TCOSCI_EN; - outw(DEFAULT_PMBASE + GPE0_EN, reg16); + outw(reg16, DEFAULT_PMBASE + GPE0_EN); } static void gma_func0_init(struct device *dev)