mb/google/skyrim: use gpio.h include

Replace the amdblocks/gpio.h and soc/gpio.h includes with the common
gpio.h which will include soc/gpio.h which will include amdblocks/gpio.h
in the AMD SoC case.
Since baseboard/ec.h and indirectly baseboard/gpio.h files will get
included in the DSDT, the soc/gpio.h includes in those aren't replaced
with a gpio.h include for now.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ib982e338b5c6bc145ec1a8f6dd75175a42dfb426
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70436
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2022-12-06 21:29:49 +01:00
parent fa0bf5c2a4
commit 8d1ef734a2
11 changed files with 11 additions and 9 deletions

View File

@ -1,10 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <acpi/acpi.h> #include <acpi/acpi.h>
#include <amdblocks/gpio.h>
#include <amdblocks/smi.h> #include <amdblocks/smi.h>
#include <console/console.h> #include <console/console.h>
#include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/ec.h>
#include <gpio.h>
#include <soc/smi.h> #include <soc/smi.h>
#include <variant/ec.h> #include <variant/ec.h>

View File

@ -1,7 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <soc/gpio.h> #include <gpio.h>
#include <soc/platform_descriptors.h> #include <soc/platform_descriptors.h>
#include <types.h> #include <types.h>

View File

@ -3,7 +3,7 @@
#include <baseboard/gpio.h> #include <baseboard/gpio.h>
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <commonlib/helpers.h> #include <commonlib/helpers.h>
#include <soc/gpio.h> #include <gpio.h>
/* GPIO configuration in ramstage*/ /* GPIO configuration in ramstage*/
static const struct soc_amd_gpio base_gpio_table[] = { static const struct soc_amd_gpio base_gpio_table[] = {

View File

@ -6,6 +6,7 @@
#include <ec/ec.h> #include <ec/ec.h>
#include <ec/google/chromeec/ec_commands.h> #include <ec/google/chromeec/ec_commands.h>
#include <baseboard/gpio.h> #include <baseboard/gpio.h>
/* Since this ends up being included in dsdt.asl, <gpio.h> can't be included instead */
#include <soc/gpio.h> #include <soc/gpio.h>
#define MAINBOARD_EC_SCI_EVENTS \ #define MAINBOARD_EC_SCI_EVENTS \

View File

@ -3,6 +3,7 @@
#ifndef __BASEBOARD_GPIO_H__ #ifndef __BASEBOARD_GPIO_H__
#define __BASEBOARD_GPIO_H__ #define __BASEBOARD_GPIO_H__
/* Since this ends up being included in dsdt.asl, <gpio.h> can't be included instead */
#include <soc/gpio.h> #include <soc/gpio.h>
/* SPI Write protect */ /* SPI Write protect */

View File

@ -3,7 +3,7 @@
#ifndef __BASEBOARD_VARIANTS_H__ #ifndef __BASEBOARD_VARIANTS_H__
#define __BASEBOARD_VARIANTS_H__ #define __BASEBOARD_VARIANTS_H__
#include <amdblocks/gpio.h> #include <gpio.h>
#include <soc/pci_devs.h> #include <soc/pci_devs.h>
#include <platform_descriptors.h> #include <platform_descriptors.h>

View File

@ -1,12 +1,12 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <amdblocks/gpio.h>
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <console/console.h> #include <console/console.h>
#include <cpu/x86/smm.h> #include <cpu/x86/smm.h>
#include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/ec.h>
#include <ec/google/chromeec/smm.h> #include <ec/google/chromeec/smm.h>
#include <elog.h> #include <elog.h>
#include <gpio.h>
#include <variant/ec.h> #include <variant/ec.h>
void mainboard_smi_sleep(u8 slp_typ) void mainboard_smi_sleep(u8 slp_typ)

View File

@ -1,7 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <security/tpm/tis.h> #include <security/tpm/tis.h>
#include <soc/gpio.h> #include <gpio.h>
int tis_plat_irq_status(void) int tis_plat_irq_status(void)
{ {

View File

@ -3,7 +3,7 @@
#include <baseboard/gpio.h> #include <baseboard/gpio.h>
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <commonlib/helpers.h> #include <commonlib/helpers.h>
#include <soc/gpio.h> #include <gpio.h>
/* GPIO configuration in ramstage */ /* GPIO configuration in ramstage */
static const struct soc_amd_gpio override_gpio_table[] = { static const struct soc_amd_gpio override_gpio_table[] = {

View File

@ -2,7 +2,7 @@
#include <baseboard/gpio.h> #include <baseboard/gpio.h>
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <commonlib/helpers.h> #include <commonlib/helpers.h>
#include <soc/gpio.h> #include <gpio.h>
/* GPIO configuration in ramstage */ /* GPIO configuration in ramstage */
static const struct soc_amd_gpio override_gpio_table[] = { static const struct soc_amd_gpio override_gpio_table[] = {

View File

@ -1,9 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <amdblocks/acpimmio.h> #include <amdblocks/acpimmio.h>
#include <amdblocks/gpio.h>
#include <arch/io.h> #include <arch/io.h>
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <gpio.h>
#include <psp_verstage.h> #include <psp_verstage.h>
#include <security/vboot/vboot_common.h> #include <security/vboot/vboot_common.h>
#include <soc/espi.h> #include <soc/espi.h>