GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/mtrr/debug: use MTRR_PHYS_MASK 

Instead adding 1 to the result of MTRR_PHYS_BASE(index) to get the
variable MTRR's mask MSR number, use the MTRR_PHYS_MASK macro.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ieecc57feb25afa83f3a53384e5a286f2e4e82093
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78006
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
Felix Held 2023-09-19 18:06:00 +02:00
parent 45343719c1
commit 8d8ed454db
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cpu/x86/mtrr/debug.c
View File

@ -98,12 +98,11 @@ static void display_mtrr_def_type(void)
static void display_variable_mtrr(int index, uint64_t address_mask)
{
const uint32_t msr_reg = MTRR_PHYS_BASE(index);
uint64_t base_address;
uint64_t length;
uint64_t mask;
const msr_t msr_a = rdmsr(msr_reg);
const msr_t msr_m = rdmsr(msr_reg + 1);
const msr_t msr_a = rdmsr(MTRR_PHYS_BASE(index));
const msr_t msr_m = rdmsr(MTRR_PHYS_MASK(index));
if (msr_m.raw & MTRR_PHYS_MASK_VALID) {
base_address = (msr_a.raw & 0xfffffffffffff000ULL)