GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfs_spi: Enable speed logging by default for BIOS_DEBUG 

The SPI transfer speed logging in cbfs_spi is super useful, doesn't get
in the way (just adding one line per stage, essentially) and should have
no notable overhead. Let's enable it by default for the BIOS_DEBUG log
level rather than having to recompile to get it.

Also fix an issue with building this code on MIPS due to lack of 64-bit
division primitives. (This means MIPS and arm32 board may display
incorrect results when reading more than 4MB in a single transfer, which
sounds very unlikely.)

Change-Id: I03c77938afe01fdcecf917e8c4c25cc29cdc764e
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33281
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Julius Werner 2019-06-06 17:35:25 -07:00
parent 092fa8bba8
commit 8dcf24fcbf
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/drivers/spi/cbfs_spi.c
View File

@ -31,21 +31,18 @@ static struct spi_flash spi_flash_info;
static bool spi_flash_init_done; static bool spi_flash_init_done;
/* /*
* Set this to 1 to debug SPI speed, 0 to disable it * SPI speed logging for big transfers available with BIOS_DEBUG. The format is:
* The format is:
* *
* read SPI 62854 7db7: 10416 us, 3089 KB/s, 24.712 Mbps * read SPI 0x62854 0x7db7: 10416 us, 3089 KB/s, 24.712 Mbps
* *
* The important number is the last one. It should roughly match your SPI * The important number is the last one. It should roughly match your SPI
* clock. If it doesn't, your driver might need a little tuning. * clock. If it doesn't, your driver might need a little tuning.
*/ */
#define SPI_SPEED_DEBUG 0
static ssize_t spi_readat(const struct region_device *rd, void *b, static ssize_t spi_readat(const struct region_device *rd, void *b,
size_t offset, size_t size) size_t offset, size_t size)
{ {
struct stopwatch sw; struct stopwatch sw;
bool show = SPI_SPEED_DEBUG && size >= 4 * KiB; bool show = size >= 4 * KiB && console_log_level(BIOS_DEBUG);
if (show) if (show)
stopwatch_init(&sw); stopwatch_init(&sw);
@ -58,7 +55,7 @@ static ssize_t spi_readat(const struct region_device *rd, void *b,
u64 speed; /* KiB/s */ u64 speed; /* KiB/s */
int bps; /* Bits per second */ int bps; /* Bits per second */
speed = (u64)size * 1000 / usecs; speed = size * 1000 / usecs;
bps = speed * 8; bps = speed * 8;
printk(BIOS_DEBUG, "read SPI %#zx %#zx: %ld us, %lld KB/s, %d.%03d Mbps\n", printk(BIOS_DEBUG, "read SPI %#zx %#zx: %ld us, %lld KB/s, %d.%03d Mbps\n",