From 8e0d1936a2b7d9cccaa4d46952061eec8b16e1b2 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Thu, 24 Jun 2021 12:58:52 +0000 Subject: [PATCH] ec/roda/it8518/acpi: Don't hard-code GPE offset The GPE offset of 16 is PCH specific. Built roda/rw11 with `BUILD_TIMELESS=1` and coreboot.rom remains the same. Change-Id: I4ec38fc28d2436f84a090bb4ab38f20612cfd795 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/56080 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/ec/roda/it8518/acpi/ec.asl | 2 +- src/mainboard/roda/rv11/acpi/ec.asl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ec/roda/it8518/acpi/ec.asl b/src/ec/roda/it8518/acpi/ec.asl index de121c6226..28f9c88eb6 100644 --- a/src/ec/roda/it8518/acpi/ec.asl +++ b/src/ec/roda/it8518/acpi/ec.asl @@ -6,7 +6,7 @@ Device (EC0) { Name (_HID, EISAID ("PNP0C09")) // ACPI Embedded Controller Name (_UID, 1) - Name (_GPE, Add(EC_SCI_GPI, 16)) // GPE for Runtime SCI + Name (_GPE, EC_SCI_GPI) Name (PWRS, 1) Name (LIDS, 1) diff --git a/src/mainboard/roda/rv11/acpi/ec.asl b/src/mainboard/roda/rv11/acpi/ec.asl index e34393002d..468a329237 100644 --- a/src/mainboard/roda/rv11/acpi/ec.asl +++ b/src/mainboard/roda/rv11/acpi/ec.asl @@ -1,4 +1,4 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#define EC_SCI_GPI 7 +#define EC_SCI_GPI (16 + 7) #include