From 8e1bb93fb88bc9cc20aab33a1fe09fb4c0c652a0 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Mon, 23 Jan 2023 10:27:51 -0700 Subject: [PATCH] mb/google/skyrim: Update ASPM settings for the NVMe device This enables L1.2 for the SSD port. link_hotplug is unused on Mendocino, so remove it while I'm here, just as code cleanup. This has no functional difference. Enabling L1.2 on other devices currently causes problems. Debug is ongoing. BUG=b:265890321 TEST=Build & boot, look at states enabled in lspci. Test device functionality. Signed-off-by: Martin Roth Change-Id: I8940856a127c8a4ba45148cbbf07a08b621beb4d Reviewed-on: https://review.coreboot.org/c/coreboot/+/72391 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Eric Lai --- src/mainboard/google/skyrim/port_descriptors.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index d745bd7e1d..0046a33a06 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -16,7 +16,6 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .link_speed_capability = GEN3, .turn_off_unused_lanes = true, .link_aspm = ASPM_L1, - .link_hotplug = 3, .clk_req = CLK_REQ2, }, { /* SD */ @@ -29,7 +28,6 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .link_speed_capability = GEN3, .turn_off_unused_lanes = true, .link_aspm = ASPM_L1, - .link_hotplug = 3, .gpio_group_id = GPIO_27, .clk_req = CLK_REQ1, }, @@ -43,7 +41,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .link_speed_capability = GEN3, .turn_off_unused_lanes = true, .link_aspm = ASPM_L1, - .link_hotplug = 3, + .link_aspm_L1_2 = true, .gpio_group_id = GPIO_6, .clk_req = CLK_REQ0, },