diff --git a/src/soc/intel/xeon_sp/finalize.c b/src/soc/intel/xeon_sp/finalize.c index 76e3ef1125..33a4d435d3 100644 --- a/src/soc/intel/xeon_sp/finalize.c +++ b/src/soc/intel/xeon_sp/finalize.c @@ -3,12 +3,15 @@ #include #include #include +#include #include #include #include +#include #include #include #include +#include #include "chip.h" @@ -23,6 +26,32 @@ static void lock_pam0123(void) pci_or_config32(dev, SAD_ALL_PAM0123_CSR, PAM_LOCK); } +DECLARE_SPIN_LOCK(msr_ppin_lock); + +static void lock_msr_ppin_ctl(void *unused) +{ + msr_t msr; + + msr = rdmsr(MSR_PLATFORM_INFO); + if ((msr.lo & MSR_PPIN_CAP) == 0) + return; + + spin_lock(&msr_ppin_lock); + + msr = rdmsr(MSR_PPIN_CTL); + if (msr.lo & MSR_PPIN_CTL_LOCK) { + spin_unlock(&msr_ppin_lock); + return; + } + + /* Clear enable and lock it */ + msr.lo &= ~MSR_PPIN_CTL_ENABLE; + msr.lo |= MSR_PPIN_CTL_LOCK; + wrmsr(MSR_PPIN_CTL, msr); + + spin_unlock(&msr_ppin_lock); +} + static void soc_finalize(void *unused) { printk(BIOS_DEBUG, "Finalizing chipset.\n"); @@ -43,6 +72,14 @@ static void soc_finalize(void *unused) apm_control(APM_CNT_FINALIZE); lock_pam0123(); + if (CONFIG_MAX_SOCKET > 1) { + /* This MSR is package scope but run for all cpus for code simplicity */ + if (mp_run_on_all_cpus(&lock_msr_ppin_ctl, NULL) != CB_SUCCESS) + printk(BIOS_ERR, "Lock PPIN CTL MSR failed\n"); + } else { + lock_msr_ppin_ctl(NULL); + } + post_code(POST_OS_BOOT); } diff --git a/src/soc/intel/xeon_sp/util.c b/src/soc/intel/xeon_sp/util.c index 0c8e63a640..525efc5add 100644 --- a/src/soc/intel/xeon_sp/util.c +++ b/src/soc/intel/xeon_sp/util.c @@ -68,9 +68,6 @@ msr_t read_msr_ppin(void) wrmsr(MSR_PPIN_CTL, msr); } ppin = rdmsr(MSR_PPIN); - /* Set enable to 0 after reading MSR_PPIN */ - msr.lo &= ~MSR_PPIN_CTL_ENABLE; - wrmsr(MSR_PPIN_CTL, msr); return ppin; }