GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/lib: Update Makefile to keep build/spd.bin rule private 

The rule to make spd.bin that's in src/lib is for the 'generic_spd_bin'
implementation.  It wasn't guarded though, so it was generating a build
warning for any other platform that generated an spd.bin file.

Sample warning that this fixes:
src/mainboard/gizmosphere/gizmo/Makefile.inc:42:
warning: overriding recipe for target 'build/spd.bin'
src/lib/Makefile.inc:298: warning: ignoring old recipe for target
'build/spd.bin'

Change-Id: Iadd6743f8ae476969bf36f99b918f04c04172d1d
Signed-off-by: Martin Roth <gaumless@gmail.com>
Reviewed-on: https://review.coreboot.org/18261
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Martin Roth 2017-01-29 18:11:36 -07:00 committed by Martin Roth
parent 545edca577
commit 8e4bb3164a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/Makefile.inc
View File

@ -287,6 +287,7 @@ ramstage-$(CONFIG_HAVE_MONOTONIC_TIMER) += hw-time-timer.adb
endif # CONFIG_RAMSTAGE_LIBHWBASE endif # CONFIG_RAMSTAGE_LIBHWBASE
ifeq ($(CONFIG_GENERIC_SPD_BIN),y)
romstage-$(CONFIG_GENERIC_SPD_BIN) += spd_bin.c romstage-$(CONFIG_GENERIC_SPD_BIN) += spd_bin.c
LIB_SPD_BIN = $(obj)/spd.bin LIB_SPD_BIN = $(obj)/spd.bin
@ -304,3 +305,4 @@ $(LIB_SPD_BIN): $(LIB_SPD_DEPS)
cbfs-files-$(CONFIG_GENERIC_SPD_BIN) += spd.bin cbfs-files-$(CONFIG_GENERIC_SPD_BIN) += spd.bin
spd.bin-file := $(LIB_SPD_BIN) spd.bin-file := $(LIB_SPD_BIN)
spd.bin-type := spd spd.bin-type := spd
endif