GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/amd/mct_ddr3: Properly initialize arrays and add bounds checks 

A couple of arrays were not properly initialized.  This
did not appear to affect operation of the codebase however
it led to some ugly values being displayed when debugging
was turned on.

Also bounds check an array index; as before this did not
appear to affect operation but was a potential point of
failure.

Change-Id: I243b7197a74aed78ddca808eb3b0f35f1fe9d95a
Signed-off-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Reviewed-on: https://review.coreboot.org/13934
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply@raptorengineeringinc.com>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Timothy Pearson 2016-03-07 14:30:47 -06:00 committed by Martin Roth
parent bbfcf62512
commit 8eb221deaf
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c
View File

@ -1717,6 +1717,7 @@ static void TrainDQSReceiverEnCyc_D_Fam15(struct MCTStatStruc *pMCTstat,
/* 2.10.5.8.3 */ /* 2.10.5.8.3 */
Receiver = mct_InitReceiver_D(pDCTstat, dct); Receiver = mct_InitReceiver_D(pDCTstat, dct);
/* Indicate success unless training the DCT explicitly fails */
dct_training_success = 1; dct_training_success = 1;
/* There are four receiver pairs, loosely associated with chipselects. /* There are four receiver pairs, loosely associated with chipselects.
@ -1729,8 +1730,9 @@ static void TrainDQSReceiverEnCyc_D_Fam15(struct MCTStatStruc *pMCTstat,
continue; continue;
} }
for (lane = 0; lane < MAX_BYTE_LANES; lane++) /* Initialize variables */
lane_training_success[lane] = 0; memset(lane_training_success, 0, sizeof(lane_training_success));
memset(current_phy_phase_delay, 0, sizeof(current_phy_phase_delay));
/* 2.10.5.8.3 (2) */ /* 2.10.5.8.3 (2) */
read_dqs_receiver_enable_control_registers(initial_phy_phase_delay, dev, dct, dimm, index_reg); read_dqs_receiver_enable_control_registers(initial_phy_phase_delay, dev, dct, dimm, index_reg);
@ -1792,13 +1794,16 @@ static void TrainDQSReceiverEnCyc_D_Fam15(struct MCTStatStruc *pMCTstat,
#endif #endif
/* 2.10.5.8.3 (5) */ /* 2.10.5.8.3 (5) */
prev = 0; prev = dqs_results_array[rx_en_offset];
for (current_phy_phase_delay[lane] = rx_en_offset; current_phy_phase_delay[lane] < 0x3ff; current_phy_phase_delay[lane] += ren_step) { for (current_phy_phase_delay[lane] = rx_en_offset + ren_step; current_phy_phase_delay[lane] < 0x3ff; current_phy_phase_delay[lane] += ren_step) {
if ((dqs_results_array[current_phy_phase_delay[lane]] == 0) && (prev == 1)) { if ((dqs_results_array[current_phy_phase_delay[lane]] == 0) && (prev == 1)) {
/* Restore last known good delay */ /* Restore last known good delay */
current_phy_phase_delay[lane] -= ren_step; current_phy_phase_delay[lane] -= ren_step;
/* 2.10.5.8.3 (5 A B) */ /* 2.10.5.8.3 (5 A B) */
if (current_phy_phase_delay[lane] < 0x10)
current_phy_phase_delay[lane] = 0x0;
else
current_phy_phase_delay[lane] -= 0x10; current_phy_phase_delay[lane] -= 0x10;
/* Update hardware registers with final values */ /* Update hardware registers with final values */