GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/stoneyridge,picasso: Switch SMM lock condition 

SMM_TSEG is a qualifier between TSEG and ASEG memory
region. ASEG is deprecated and not supported for
this platform in coreboot codebase.

The SMM lock should be set based on whether SMM is
installed or not, HAVE_SMI_HANDLER currently tells
that.

Change-Id: I9756f8a59ccfedd59d5b997b35313452dd0c4f46
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34127
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki 2019-07-08 09:16:13 +03:00
parent 60012ac64e
commit 8f076f2be8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/picasso/finalize.c
View File

@ -29,7 +29,7 @@ static void per_core_finalize(void *unused)
if (hwcr.lo & SMM_LOCK) /* Skip if already locked, avoid GPF */ if (hwcr.lo & SMM_LOCK) /* Skip if already locked, avoid GPF */
return; return;
if (CONFIG(SMM_TSEG)) { if (CONFIG(HAVE_SMI_HANDLER)) {
mask = rdmsr(SMM_MASK_MSR); mask = rdmsr(SMM_MASK_MSR);
mask.lo |= SMM_TSEG_VALID; mask.lo |= SMM_TSEG_VALID;
wrmsr(SMM_MASK_MSR, mask); wrmsr(SMM_MASK_MSR, mask);

2
src/soc/amd/stoneyridge/finalize.c
View File

@ -29,7 +29,7 @@ static void per_core_finalize(void *unused)
if (hwcr.lo & SMM_LOCK) /* Skip if already locked, avoid GPF */ if (hwcr.lo & SMM_LOCK) /* Skip if already locked, avoid GPF */
return; return;
if (CONFIG(SMM_TSEG)) { if (CONFIG(HAVE_SMI_HANDLER)) {
mask = rdmsr(SMM_MASK_MSR); mask = rdmsr(SMM_MASK_MSR);
mask.lo |= SMM_TSEG_VALID; mask.lo |= SMM_TSEG_VALID;
wrmsr(SMM_MASK_MSR, mask); wrmsr(SMM_MASK_MSR, mask);