GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

payloads/tianocore: Increase default timeout for SD MMC init to 10ms 

Firstly, change the unit of `μs` to `ms` so it's easier to read.

This patch changes the default amount of time allowed to initialise
SD Card Readers and eMMC drives from 1ms to 10ms. Having a timeout
too short will stop certain devices from booting, which was seen on
google/akemi; it throws an exception when attempting to boot from
the internal eMMC drive.

This new value is still lower than upstream edk2's value of 1s.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: Id1f66d5d50f889f07a34836ab2932b28ef7fb245
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65813
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
This commit is contained in:
Sean Rhodes 2022-07-13 08:09:59 +01:00 committed by Martin L Roth
parent 900be57aee
commit 8f296038e5
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
payloads/external/tianocore/Kconfig vendored
View File

@ -169,11 +169,11 @@ config TIANOCORE_PS2_SUPPORT
Include support for PS/2 keyboards Include support for PS/2 keyboards
config TIANOCORE_SD_MMC_TIMEOUT config TIANOCORE_SD_MMC_TIMEOUT
int "Timeout in μs for initializing SD Card reader" int "Timeout in ms for initializing SD and eMMC devices"
default 1000 default 10
help help
The amount of time allowed to initialize the SD Card reader and/or eMMC drive. The amount of time allowed to initialize the SD Card reader and/or eMMC drive.
Most only require 1000μs, but certain readers can take 1000000μs. Most only require 10ms, but certain readers can take 1s.
config TIANOCORE_SERIAL_SUPPORT config TIANOCORE_SERIAL_SUPPORT
bool "Support serial output" bool "Support serial output"

2
payloads/external/tianocore/Makefile vendored
View File

@ -78,7 +78,7 @@ BUILD_STR += -D USE_CBMEM_FOR_CONSOLE=TRUE
endif endif
# SD_MMC_TIMEOUT = 1000000 # SD_MMC_TIMEOUT = 1000000
ifneq ($(CONFIG_TIANOCORE_SD_MMC_TIMEOUT),) ifneq ($(CONFIG_TIANOCORE_SD_MMC_TIMEOUT),)
BUILD_STR += -D SD_MMC_TIMEOUT=$(CONFIG_TIANOCORE_SD_MMC_TIMEOUT) BUILD_STR += -D SD_MMC_TIMEOUT=$(call int-multiply, $(CONFIG_TIANOCORE_SD_MMC_TIMEOUT) 1000)
endif endif
# #
# EDKII has the below PCDs that are revalant to coreboot: # EDKII has the below PCDs that are revalant to coreboot: