soc/intel/skylake: Move `SataTestMode` to Kconfig

This option is not mainboard-specific, and should be user-visible.

Change-Id: I9ff2ca984cd238a112af4efd7685f142cc6e5459
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52099
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>

src/mainboard/hp/280_g2/devicetree.cb

@@ -75,9 +75,6 @@ chip soc/intel/skylake
 				[3] = 1,
 			}"
 			# DevSlp not supported
-
-			# Enable test mode for SATA margining
-			register "SataTestMode" = "1"
 		end
 		device pci 19.0 on  end		# UART #2
 		device pci 1c.0 off end		# RP #1

src/soc/intel/skylake/Kconfig

@@ -91,6 +91,12 @@ config FSP_HYPERTHREADING
 	bool "Enable Hyper-Threading"
 	default y
 
+config ENABLE_SATA_TEST_MODE
+	bool "Enable SATA test mode"
+	default n
+	help
+	  Enable SATA test mode in FSP-S.
+
 config CPU_INTEL_NUM_FIT_ENTRIES
 	int
 	default 10

src/soc/intel/skylake/chip.c

@@ -304,7 +304,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
 		 * write" errors and others. Enabling this option solves these problems.
 		 */
 		params->SataPwrOptEnable = 1;
-		tconfig->SataTestMode = config->SataTestMode;
+		tconfig->SataTestMode = CONFIG(ENABLE_SATA_TEST_MODE);
 	}
 
 	memcpy(params->PcieRpClkReqSupport, config->PcieRpClkReqSupport,

src/soc/intel/skylake/chip.h

@@ -477,9 +477,6 @@ struct soc_intel_skylake_config {
 	 */
 	u8 IslVrCmd;
 
-	/* Enable/Disable Sata test mode */
-	u8 SataTestMode;
-
 	/* i915 struct for GMA backlight control */
 	struct i915_gpu_controller_info gfx;
 };