GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/ite/it8661f: Make early_serial into romstage sym 

Following similar reasoning as commit:
d304331 superio/fintek/f81865f: Avoid .c includes

Avoid any mistaken future inclusion of early_serial.c in mainboard.c
code by providing symbols in romstage.

Change-Id: I9e763a7ad9de090e35acdcf4d6a280d8227c6015
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5508
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Edward O'Callaghan 2014-04-15 20:30:49 +10:00 committed by Kyösti Mälkki
parent 6fb379a1db
commit 8f45761a67
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/superio/ite/it8661f/Makefile.inc
View File

@ -18,5 +18,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
## ##
romstage-$(CONFIG_SUPERIO_ITE_IT8661F) += early_serial.c
ramstage-$(CONFIG_SUPERIO_ITE_IT8661F) += superio.c ramstage-$(CONFIG_SUPERIO_ITE_IT8661F) += superio.c

3
src/superio/ite/it8661f/early_serial.c
View File

@ -19,6 +19,7 @@
*/ */
#include <arch/io.h> #include <arch/io.h>
#include <device/pnp.h>
#include "it8661f.h" #include "it8661f.h"
/* Perform MB PnP setup to put the SIO chip at 0x3f0. */ /* Perform MB PnP setup to put the SIO chip at 0x3f0. */
@ -68,7 +69,7 @@ static void it8661f_set_clkin(device_t dev, u8 clkin)
pnp_exit_ext_func_mode(dev); pnp_exit_ext_func_mode(dev);
} }
static void it8661f_enable_serial(device_t dev, u16 iobase) void it8661f_enable_serial(device_t dev, u16 iobase)
{ {
pnp_enter_ext_func_mode(dev); pnp_enter_ext_func_mode(dev);
pnp_set_logical_device(dev); pnp_set_logical_device(dev);

8
src/superio/ite/it8661f/it8661f.h
View File

@ -18,8 +18,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#ifndef SUPERIO_ITE_IT8661F_IT8661F_H #ifndef SUPERIO_ITE_IT8661F_H
#define SUPERIO_ITE_IT8661F_IT8661F_H #define SUPERIO_ITE_IT8661F_H
/* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8661_2.asp */ /* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8661_2.asp */
@ -52,4 +52,6 @@ static const u8 init_values[] = {
0xe8, 0x74, 0x3a, 0x9d, /**/ 0xce, 0xe7, 0x73, 0x39, 0xe8, 0x74, 0x3a, 0x9d, /**/ 0xce, 0xe7, 0x73, 0x39,
}; };
#endif void it8661f_enable_serial(device_t dev, u16 iobase);
#endif /* SUPERIO_ITE_IT8661F_H */