GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/acpi: Don't wait for PG in GPU off sequences 

When powering rails down, there is no value in waiting for the PG
signal to de-assert. Instead, shut the rails off as quickly as possible
while maintaining a controlled ordering.

BUG=b:288266850
TEST=build and measured delays are gone
Signed-off-by: Tarun Tuli <taruntuli@google.com>

Change-Id: If31691a7d62b72661fcbacb34e90f3a6adec8134
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76050
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Tarun Tuli 2023-06-21 19:35:27 +00:00 committed by Nick Vaccaro
parent 24d2ee9447
commit 8f6af5ba13
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/mainboard/google/brya/acpi/power.asl
View File

@ -137,7 +137,6 @@ Method (GC6I, 0, Serialized)
/* Ramp down PEXVDD */ /* Ramp down PEXVDD */
CTXS (GPIO_PEXVDD_PWR_EN) CTXS (GPIO_PEXVDD_PWR_EN)
GPPL (GPIO_PEXVDD_PG, 0, 20)
#if CONFIG(BOARD_GOOGLE_AGAH) #if CONFIG(BOARD_GOOGLE_AGAH)
Sleep (10) Sleep (10)
#else #else
@ -146,7 +145,6 @@ Method (GC6I, 0, Serialized)
/* Deassert EN_PPVAR_GPU_NVVDD */ /* Deassert EN_PPVAR_GPU_NVVDD */
CTXS (GPIO_NVVDD_PWR_EN) CTXS (GPIO_NVVDD_PWR_EN)
GPPL (NVPG, 0, 20)
Sleep (2) Sleep (2)
/* Assert GPU_PERST_L */ /* Assert GPU_PERST_L */
@ -280,40 +278,34 @@ Method (PGOF, 0, Serialized)
CTXS (GPIO_GPU_ALLRAILS_PG) CTXS (GPIO_GPU_ALLRAILS_PG)
Sleep (1) Sleep (1)
/* Ramp down FBVDD and let rail discharge to <10% */ /* Ramp down FBVDD */
#if CONFIG(BOARD_GOOGLE_AGAH) #if CONFIG(BOARD_GOOGLE_AGAH)
STXS (GPIO_FBVDD_PWR_EN) STXS (GPIO_FBVDD_PWR_EN)
#else #else
CTXS (GPIO_FBVDD_PWR_EN) CTXS (GPIO_FBVDD_PWR_EN)
#endif #endif
GPPL (GPIO_FBVDD_PG, 0, 20)
/* Ramp down PEXVDD and let rail discharge to <10% */ /* Ramp down PEXVDD and let rail discharge to <10% */
CTXS (GPIO_PEXVDD_PWR_EN) CTXS (GPIO_PEXVDD_PWR_EN)
GPPL (GPIO_PEXVDD_PG, 0, 20)
#if CONFIG(BOARD_GOOGLE_AGAH) #if CONFIG(BOARD_GOOGLE_AGAH)
Sleep (10) Sleep (10)
#else #else
Sleep (3) Sleep (3)
#endif #endif
/* Ramp down NVVDD and let rail discharge to <10% */ /* Ramp down NVVDD */
CTXS (GPIO_NVVDD_PWR_EN) CTXS (GPIO_NVVDD_PWR_EN)
GPPL (NVPG, 0, 20)
Sleep (2) Sleep (2)
/* Ramp down NV33 and let rail discharge to <10% */ /* Ramp down NV33 */
CTXS (GPIO_NV33_PWR_EN) CTXS (GPIO_NV33_PWR_EN)
GPPL (GPIO_NV33_PG, 0, 20)
Sleep (4) Sleep (4)
/* Ramp down 1.8V */ /* Ramp down 1.8V */
CTXS (GPEN) CTXS (GPEN)
GPPL (GPIO_1V8_PG, 0, 20)
/* Ramp down 1.2V rail on boards with support */ /* Ramp down 1.2V rail on boards with support */
CTXS (GPIO_NV12_PWR_EN) CTXS (GPIO_NV12_PWR_EN)
GPPL (GPIO_NV12_PG, 0, 5)
GCOT = Timer GCOT = Timer