GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common: Make AGESA event log parser static 

The function agesawrapper_readeventlog() is not used outside of the
wrapper.  Relocate it within the file and make it static.

Change-Id: Ia7fefb4eadbace0cc2fb0f519a1acb7906baaf12
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/22902
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Marshall Dawson 2017-12-15 12:01:41 -07:00 committed by Martin Roth
parent 3aed84aa46
commit 8f6cd22087
2 changed files with 28 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/amd/common/block/include/amdblocks/agesawrapper.h
View File

@ -40,7 +40,6 @@ AGESA_STATUS agesawrapper_amdinitenv(void);
AGESA_STATUS agesawrapper_amdinitlate(void);
AGESA_STATUS agesawrapper_amdinitpost(void);
AGESA_STATUS agesawrapper_amdinitmid(void);
AGESA_STATUS agesawrapper_readeventlog(UINT8 HeapStatus);
void *agesawrapper_getlateinitptr(int pick);
AGESA_STATUS agesawrapper_amdlaterunaptask(UINT32 Func, UINTN Data,
void *ConfigPtr);

56
src/soc/amd/common/block/pi/agesawrapper.c
View File

@ -40,6 +40,34 @@ static void *AcpiIvrs;
static void *AcpiCrat;
#endif /* #ifndef __PRE_RAM__ */
static AGESA_STATUS agesawrapper_readeventlog(UINT8 HeapStatus)
{
AGESA_STATUS Status;
EVENT_PARAMS AmdEventParams = {
.StdHeader.CalloutPtr = &GetBiosCallout,
.StdHeader.HeapStatus = HeapStatus,
};
Status = AmdReadEventLog(&AmdEventParams);
if (AmdEventParams.EventClass)
printk(BIOS_DEBUG, "AGESA Event Log:\n");
while (AmdEventParams.EventClass != 0) {
printk(BIOS_DEBUG, " Class = %x, Info = %x,"
" Param1 = 0x%x, Param2 = 0x%x"
" Param3 = 0x%x, Param4 = 0x%x\n",
(u32)AmdEventParams.EventClass,
(u32)AmdEventParams.EventInfo,
(u32)AmdEventParams.DataParam1,
(u32)AmdEventParams.DataParam2,
(u32)AmdEventParams.DataParam3,
(u32)AmdEventParams.DataParam4);
Status = AmdReadEventLog(&AmdEventParams);
}
return Status;
}
AGESA_STATUS agesawrapper_amdinitreset(void)
{
AGESA_STATUS status;
@ -363,34 +391,6 @@ AGESA_STATUS agesawrapper_amdlaterunaptask (
return Status;
}
AGESA_STATUS agesawrapper_readeventlog(UINT8 HeapStatus)
{
AGESA_STATUS Status;
EVENT_PARAMS AmdEventParams = {
.StdHeader.CalloutPtr = &GetBiosCallout,
.StdHeader.HeapStatus = HeapStatus,
};
Status = AmdReadEventLog(&AmdEventParams);
if (AmdEventParams.EventClass)
printk(BIOS_DEBUG, "AGESA Event Log:\n");
while (AmdEventParams.EventClass != 0) {
printk(BIOS_DEBUG, " Class = %x, Info = %x,"
" Param1 = 0x%x, Param2 = 0x%x"
" Param3 = 0x%x, Param4 = 0x%x\n",
(u32)AmdEventParams.EventClass,
(u32)AmdEventParams.EventInfo,
(u32)AmdEventParams.DataParam1,
(u32)AmdEventParams.DataParam2,
(u32)AmdEventParams.DataParam3,
(u32)AmdEventParams.DataParam4);
Status = AmdReadEventLog(&AmdEventParams);
}
return Status;
}
static int agesa_locate_file(const char *name, struct region_device *rdev,
uint32_t type)
{