From 8f731b847e488da21372f5f6e22b876bb70d04aa Mon Sep 17 00:00:00 2001 From: Tristan Corrick Date: Wed, 1 Aug 2018 03:08:53 +1200 Subject: [PATCH] superio/acpi: Make _CRS methods Serialized, eliminating IASL remarks When compiling for the ASUS P8H61-M LX, IASL 20180531 emits the following remark: "Control Method should be made Serialized (due to creation of named objects within)". Making the appropriate methods Serialized eliminates these remarks. Change-Id: I8e95d9a00a629a2f904c79b78fac20810327ed37 Signed-off-by: Tristan Corrick Reviewed-on: https://review.coreboot.org/27796 Reviewed-by: Felix Held Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/superio/acpi/pnp_generic.asl | 2 +- src/superio/acpi/pnp_kbc.asl | 6 +++--- src/superio/acpi/pnp_uart.asl | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl index c878827cbd..980404efdd 100644 --- a/src/superio/acpi/pnp_generic.asl +++ b/src/superio/acpi/pnp_generic.asl @@ -95,7 +95,7 @@ Device (SUPERIO_ID(PN, SUPERIO_PNP_LDN)) { } #endif - Method (_CRS) + Method (_CRS, 0, Serialized) { Name (CRS, ResourceTemplate () { #ifdef SUPERIO_PNP_IO0 diff --git a/src/superio/acpi/pnp_kbc.asl b/src/superio/acpi/pnp_kbc.asl index db81ea2185..cbcfd55910 100644 --- a/src/superio/acpi/pnp_kbc.asl +++ b/src/superio/acpi/pnp_kbc.asl @@ -73,7 +73,7 @@ Device (SUPERIO_ID(KBD, SUPERIO_KBC_LDN)) { PNP_DEFAULT_PSC } - Method (_CRS) + Method (_CRS, 0, Serialized) { Name (CRS, ResourceTemplate () { IO (Decode16, 0x0000, 0x0000, 0x01, 0x01, IO0) @@ -133,7 +133,7 @@ Device (SUPERIO_ID(PS2, SUPERIO_KBC_LDN)) { Return (^^SUPERIO_ID(KBD, SUPERIO_KBC_LDN)._PSC ()) } - Method (_CRS) + Method (_CRS, 0, Serialized) { Name (CRS, ResourceTemplate () { IRQNoFlags (IR1) {} @@ -188,7 +188,7 @@ Device (SUPERIO_ID(PS2, SUPERIO_KBC_PS2LDN)) { PNP_DEFAULT_PSC } - Method (_CRS) + Method (_CRS, 0, Serialized) { Name (CRS, ResourceTemplate () { IRQNoFlags (IR1) {} diff --git a/src/superio/acpi/pnp_uart.asl b/src/superio/acpi/pnp_uart.asl index 1bbdb37fa6..f42cc42039 100644 --- a/src/superio/acpi/pnp_uart.asl +++ b/src/superio/acpi/pnp_uart.asl @@ -79,7 +79,7 @@ Device (SUPERIO_ID(SER, SUPERIO_UART_LDN)) { } #endif - Method (_CRS) + Method (_CRS, 0, Serialized) { Name (CRS, ResourceTemplate () { IO (Decode16, 0x0000, 0x0000, 0x08, 0x08, IO0)