From 8f75d79e749fc1fd0edf180fd68df30f0f30f811 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Sun, 11 Dec 2022 23:55:57 +0100 Subject: [PATCH] soc/intel/acpi: Replace LNotEqual(a,b) with ASL 2.0 syntax Replace `LNotEqual (a, b)` with `a != b`. Change-Id: Ia1bd22a62ec2868324a88400e27ed52c9f169751 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/70619 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- src/soc/intel/baytrail/acpi/southcluster.asl | 2 +- src/soc/intel/braswell/acpi/southcluster.asl | 2 +- src/soc/intel/icelake/acpi/pch_hda.asl | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/soc/intel/baytrail/acpi/southcluster.asl b/src/soc/intel/baytrail/acpi/southcluster.asl index 7da4db0f0c..94548a35db 100644 --- a/src/soc/intel/baytrail/acpi/southcluster.asl +++ b/src/soc/intel/baytrail/acpi/southcluster.asl @@ -155,7 +155,7 @@ Method (_CRS, 0, Serialized) CreateDWordField (MCRS, ^LMEM._MIN, LMIN) CreateDWordField (MCRS, ^LMEM._MAX, LMAX) CreateDWordField (MCRS, ^LMEM._LEN, LLEN) - If (LAnd (LNotEqual (LPFW, Zero), LPEN == One)) + If (LAnd (LPFW != Zero, LPEN == One)) { Store (LPFW, LMIN) Store (0x00100000, LLEN) diff --git a/src/soc/intel/braswell/acpi/southcluster.asl b/src/soc/intel/braswell/acpi/southcluster.asl index 546c699522..0e17686f8f 100644 --- a/src/soc/intel/braswell/acpi/southcluster.asl +++ b/src/soc/intel/braswell/acpi/southcluster.asl @@ -154,7 +154,7 @@ Method (_CRS, 0, Serialized) CreateDWordField (MCRS, LMEM._MIN, LMIN) CreateDWordField (MCRS, LMEM._MAX, LMAX) CreateDWordField (MCRS, LMEM._LEN, LLEN) - If (LAnd (LNotEqual (LPFW, Zero), LPEN == One)) + If (LAnd (LPFW != Zero, LPEN == One)) { Store (LPFW, LMIN) Store (Add (LMIN, 0x001FFFFF), LMAX) diff --git a/src/soc/intel/icelake/acpi/pch_hda.asl b/src/soc/intel/icelake/acpi/pch_hda.asl index d0f966a0dc..b5b5416f1c 100644 --- a/src/soc/intel/icelake/acpi/pch_hda.asl +++ b/src/soc/intel/icelake/acpi/pch_hda.asl @@ -37,8 +37,7 @@ Device (HDAS) * if NHLT address and length are set in NVS. */ If (LAnd (Arg1 == One, - LAnd (LNotEqual (NHLA, Zero), - LNotEqual (NHLL, Zero)))) { + LAnd (NHLA != Zero, NHLL != Zero))) { Return (Buffer (One) { 0x03 }) } Else { Return (Buffer (One) { 0x01 })