From 8fca63f98f183ad72e2a292cb524e23eb9423ab9 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 20:01:34 +0200 Subject: [PATCH] dell/snb_ivb_workstations: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I80bd87aa2f97da74a1bbcf05b16f0d5980e142f2 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/75072 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- src/mainboard/dell/snb_ivb_workstations/Kconfig | 8 ++++++++ src/mainboard/dell/snb_ivb_workstations/Kconfig.name | 4 ---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/mainboard/dell/snb_ivb_workstations/Kconfig b/src/mainboard/dell/snb_ivb_workstations/Kconfig index 8dcafd1036..bf211bbc89 100644 --- a/src/mainboard/dell/snb_ivb_workstations/Kconfig +++ b/src/mainboard/dell/snb_ivb_workstations/Kconfig @@ -18,6 +18,14 @@ config BOARD_DELL_SNB_IVB_WORKSTATIONS select PCIEXP_L1_SUB_STATE select DRIVERS_UART_8250IO +config BOARD_DELL_OPTIPLEX_9010 + select BOARD_DELL_SNB_IVB_WORKSTATIONS + select SOUTHBRIDGE_INTEL_C216 + +config BOARD_DELL_PRECISION_T1650 + select BOARD_DELL_SNB_IVB_WORKSTATIONS + select SOUTHBRIDGE_INTEL_C216 + if BOARD_DELL_SNB_IVB_WORKSTATIONS config MAINBOARD_DIR diff --git a/src/mainboard/dell/snb_ivb_workstations/Kconfig.name b/src/mainboard/dell/snb_ivb_workstations/Kconfig.name index 6f6d833c06..d258054539 100644 --- a/src/mainboard/dell/snb_ivb_workstations/Kconfig.name +++ b/src/mainboard/dell/snb_ivb_workstations/Kconfig.name @@ -1,9 +1,5 @@ config BOARD_DELL_OPTIPLEX_9010 bool "OptiPlex 9010 SFF" - select BOARD_DELL_SNB_IVB_WORKSTATIONS - select SOUTHBRIDGE_INTEL_C216 config BOARD_DELL_PRECISION_T1650 bool "Dell Precision T1650" - select BOARD_DELL_SNB_IVB_WORKSTATIONS - select SOUTHBRIDGE_INTEL_C216