GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/i945/raminit: Use 'bool' for do_reset 

Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: I692b86bba28853186185846f63dad1dcbfce1eea
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68217
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Elyes Haouas 2022-10-07 12:27:22 +02:00 committed by Martin L Roth
parent d9dade3cb9
commit 901566597e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/northbridge/intel/i945/raminit.c
View File

@ -216,7 +216,7 @@ static int sdram_capabilities_core_frequencies(void)
static void sdram_detect_errors(struct sys_info *sysinfo) static void sdram_detect_errors(struct sys_info *sysinfo)
{ {
u8 reg8; u8 reg8;
u8 do_reset = 0; bool do_reset = false;
reg8 = pci_read_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2); reg8 = pci_read_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2);
@ -225,7 +225,7 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
printk(BIOS_DEBUG, "SLP S4# Assertion Width Violation.\n"); printk(BIOS_DEBUG, "SLP S4# Assertion Width Violation.\n");
/* Write back clears bit 2 */ /* Write back clears bit 2 */
pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8); pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
do_reset = 1; do_reset = true;
} }
@ -233,7 +233,7 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
printk(BIOS_DEBUG, "DRAM initialization was interrupted.\n"); printk(BIOS_DEBUG, "DRAM initialization was interrupted.\n");
reg8 &= ~(1 << 7); reg8 &= ~(1 << 7);
pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8); pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
do_reset = 1; do_reset = true;
} }
/* Set SLP_S3# Assertion Stretch Enable */ /* Set SLP_S3# Assertion Stretch Enable */
@ -258,12 +258,12 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
if (((sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) || if (((sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) ||
(sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) && (sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) &&
!(mchbar_read8(SLFRCS) & (1 << 0))) { !(mchbar_read8(SLFRCS) & (1 << 0))) {
do_reset = 1; do_reset = true;
} }
if (((sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED) || if (((sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED) ||
(sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) && (sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) &&
!(mchbar_read8(SLFRCS) & (1 << 1))) { !(mchbar_read8(SLFRCS) & (1 << 1))) {
do_reset = 1; do_reset = true;
} }
} }