GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0: Avoid iterative print statement 

This patch moves "Display FSP Version Info HOB" print outside
of the loop to avoid getting called multiple times.

TEST=Able to see "Display FSP Version Info HOB" only once.

Change-Id: I754d5922f4dbef22656ca98c02d9f45791c8433d
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39827
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2020-03-25 18:40:41 +05:30
parent d4e9978793
commit 90557f4a4b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/drivers/intel/fsp2_0/hand_off_block.c
View File

@ -233,7 +233,6 @@ static void display_fsp_version_info_hob(const void *hob, size_t size)
(fvih->Count * sizeof (FIRMWARE_VERSION_INFO)));
size -= sizeof(SMBIOS_STRUCTURE);
printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
for (index = 0; index < fvih->Count; index++) {
cnt = strlen(str_ptr);
@ -282,6 +281,7 @@ void fsp_display_fvi_version_hob(void)
if (!hob)
return;
printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST;
hob = fsp_next_hob(hob)) {
if (hob->type != HOB_TYPE_GUID_EXTENSION)