GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/cbmem: Update formatting for cbmem -l command 

Some of the cbmem area names have gotten longer, and were making the
output of cbmem -l look bad, so expand the name area to 20 characters.

Instead of printing a blank area if the name isn't recognized, call it
unknown.

Change the method of printing the title to match the way the actual text
of the table is printed.

Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I9d91d21c6ad418d9fee9880550fb6cb9e41e93f0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68644
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Martin Roth 2022-10-20 21:11:30 -06:00 committed by Felix Held
parent 12459160d1
commit 90e4f3dd4c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
util/cbmem/cbmem.c
View File

@ -1185,11 +1185,10 @@ static void cbmem_print_entry(int n, uint32_t id, uint64_t base, uint64_t size)
printf("%2d. ", n); printf("%2d. ", n);
if (name == NULL) if (name == NULL)
printf("\t\t%08x", id); name = "(unknown)";
else printf("%-20s %08x", name, id);
printf("%s\t%08x", name, id);
printf(" %08" PRIx64 " ", base); printf(" %08" PRIx64 " ", base);
printf(" %08" PRIx64 "\n", size); printf(" %08" PRIx64 "\n", size);
} }
static void dump_cbmem_toc(void) static void dump_cbmem_toc(void)
@ -1204,7 +1203,8 @@ static void dump_cbmem_toc(void)
return; return;
printf("CBMEM table of contents:\n"); printf("CBMEM table of contents:\n");
printf(" NAME ID START LENGTH\n"); printf(" %-20s %-8s %-8s %-8s\n", "NAME", "ID", "START",
"LENGTH");
i = 0; i = 0;
offset = 0; offset = 0;