From 914ea8e5302a61cac9c81df9aad1d9967d844f18 Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Thu, 18 Feb 2021 09:40:15 -0700 Subject: [PATCH] mb/google/brya: Implement SLP_S0_GATE signal The SLP_S0_GATE# signal is used in conjunction with the PCH's SLP_S0# to provide an indication to the rest of the platform when the system is entering its software-initiated low-power state (i.e. S0ix). This lets the platform distinguish between opportunistic S0ix entry and the runtime suspend mechanism. BUG=b:180401723 TEST=abuild Change-Id: I7fe2e3707465778baf56283617a8485a94f2dbca Signed-off-by: Tim Wawrzynczak Reviewed-on: https://review.coreboot.org/c/coreboot/+/50881 Reviewed-by: Furquan Shaikh Reviewed-by: EricR Lai Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/dsdt.asl | 2 ++ src/mainboard/google/brya/mainboard.asl | 24 +++++++++++++++++++ .../baseboard/include/baseboard/gpio.h | 10 ++++---- 3 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 src/mainboard/google/brya/mainboard.asl diff --git a/src/mainboard/google/brya/dsdt.asl b/src/mainboard/google/brya/dsdt.asl index 7bcba7f9d7..2bfb49713e 100644 --- a/src/mainboard/google/brya/dsdt.asl +++ b/src/mainboard/google/brya/dsdt.asl @@ -22,6 +22,8 @@ DefinitionBlock( #include Scope (\_SB) { + #include "mainboard.asl" + Device (PCI0) { #include diff --git a/src/mainboard/google/brya/mainboard.asl b/src/mainboard/google/brya/mainboard.asl new file mode 100644 index 0000000000..c60db3081c --- /dev/null +++ b/src/mainboard/google/brya/mainboard.asl @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include + +/* + * S0ix Entry/Exit Notifications + * Called from \_SB.PEPD._DSM + */ +Method (MS0X, 1, Serialized) +{ + If (Arg0 == 1) { + /* + * On S0ix entry, clear the SLP_S0_GATE pin, so that the rest of + * the platform can transition to its low power state as well. + */ + \_SB.PCI0.CTXS(GPIO_SLP_S0_GATE); + } Else { + /* + * On S0ix exit, set the SLP_S0_GATE pin, so that the rest of + * the platform will resume from its low power state. + */ + \_SB.PCI0.STXS(GPIO_SLP_S0_GATE); + } +} diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h index 96e88b56d1..578fac9de9 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h @@ -7,12 +7,14 @@ #include /* eSPI virtual wire reporting */ -#define EC_SCI_GPI GPE0_ESPI +#define EC_SCI_GPI GPE0_ESPI /* EC wake is EC_PCH_INT which is routed to GPP_F17 pin */ -#define GPE_EC_WAKE GPE0_DW2_17 +#define GPE_EC_WAKE GPE0_DW2_17 /* WP signal to PCH */ -#define GPIO_PCH_WP GPP_E15 +#define GPIO_PCH_WP GPP_E15 /* EC in RW or RO */ -#define GPIO_EC_IN_RW GPP_F18 +#define GPIO_EC_IN_RW GPP_F18 +/* Used to gate SoC's SLP_S0# signal */ +#define GPIO_SLP_S0_GATE GPP_F9 #endif /* __BASEBOARD_GPIO_H__ */