GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya,primus,voxel: Update controller field for tbt_dma entries 

We need to reference correct USB port number for driver to
identify type-C port number correctly.

BUG=b:189476816
BRANCH=None
TEST=Check the transactions are happening on correct port. Also checked
retimer firmware update on both the ports.

Change-Id: I20c088ee81610155067abad086eba8d72f73ad60
Signed-off-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55946
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Maulik V Vaghela 2021-06-29 18:07:55 +05:30 committed by Patrick Georgi
parent 0f7e086229
commit 91c38c8c8d
3 changed files with 12 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/mainboard/google/brya/variants/brya0/overridetree.cb
View File

@ -165,17 +165,15 @@ chip soc/intel/alderlake
end end
device ref tcss_dma0 on device ref tcss_dma0 on
chip drivers/intel/usb4/retimer chip drivers/intel/usb4/retimer
register "dfp" = "{ register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)"
[0] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4), use tcss_usb3_port1 as dfp[0].typec_port
.group = ACPI_PLD_GROUP(1, 1),}}"
device generic 0 on end device generic 0 on end
end end
end end
device ref tcss_dma1 on device ref tcss_dma1 on
chip drivers/intel/usb4/retimer chip drivers/intel/usb4/retimer
register "dfp" = "{ register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)"
[0] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4), use tcss_usb3_port3 as dfp[0].typec_port
.group = ACPI_PLD_GROUP(3, 1)}}"
device generic 0 on end device generic 0 on end
end end
end end

10
src/mainboard/google/brya/variants/primus/overridetree.cb
View File

@ -158,17 +158,15 @@ chip soc/intel/alderlake
end #PCIE3 BH799BB end #PCIE3 BH799BB
device ref tcss_dma0 on device ref tcss_dma0 on
chip drivers/intel/usb4/retimer chip drivers/intel/usb4/retimer
register "dfp" = "{ register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)"
[0] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4), use tcss_usb3_port1 as dfp[0].typec_port
.group = ACPI_PLD_GROUP(1, 1),}}"
device generic 0 on end device generic 0 on end
end end
end end
device ref tcss_dma1 on device ref tcss_dma1 on
chip drivers/intel/usb4/retimer chip drivers/intel/usb4/retimer
register "dfp" = "{ register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4)"
[0] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E4), use tcss_usb3_port3 as dfp[0].typec_port
.group = ACPI_PLD_GROUP(3, 1)}}"
device generic 0 on end device generic 0 on end
end end
end end

9
src/mainboard/google/volteer/variants/voxel/overridetree.cb
View File

@ -220,11 +220,10 @@ chip soc/intel/tigerlake
probe DB_USB USB4_GEN2 probe DB_USB USB4_GEN2
probe DB_USB USB4_GEN3 probe DB_USB USB4_GEN3
chip drivers/intel/usb4/retimer chip drivers/intel/usb4/retimer
register "dfp" = "{ register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H10)"
[0] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H10), register "dfp[1].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H10)"
.group = ACPI_PLD_GROUP(3, 2),}, use tcss_usb3_port3 as dfp[0].typec_port
[1] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H10), use tcss_usb3_port2 as dfp[1].typec_port
.group = ACPI_PLD_GROUP(2, 2),}}"
device generic 0 on end device generic 0 on end
end end
end end