arch/x86: Avoid HAVE_SMI_HANDLER conditional with smm-class

Build of the entire smm-class is skipped if we have
HAVE_SMI_HANDLER=n.

Change-Id: I10b4300ddd18b1673c404b45fd9642488ab3186c
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34125
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Lance Zhao <lance.zhao@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/arch/x86/Makefile.inc

@@ -404,8 +404,6 @@ smm-y += memmove.c
 smm-y += memset.c
 smm-$(CONFIG_X86_TOP4G_BOOTMEDIA_MAP) += mmap_boot.c
 
-ifeq ($(CONFIG_HAVE_SMI_HANDLER),y)
 ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/smihandler.c),)
 smm-srcs += src/mainboard/$(MAINBOARDDIR)/smihandler.c
 endif
-endif

src/cpu/amd/agesa/family15tn/Makefile.inc

@@ -19,7 +19,7 @@ ramstage-y += fixme.c
 ramstage-y += chip_name.c
 ramstage-y += model_15_init.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += udelay.c
+smm-y += udelay.c
 
 subdirs-y += ../../mtrr
 subdirs-y += ../../smm

src/cpu/amd/pi/00630F01/Makefile.inc

@@ -19,7 +19,7 @@ ramstage-y += fixme.c
 ramstage-y += chip_name.c
 ramstage-y += model_15_init.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += udelay.c
+smm-y += udelay.c
 
 subdirs-y += ../../mtrr
 subdirs-y += ../../smm

src/cpu/intel/common/Makefile.inc

@@ -2,4 +2,4 @@ ramstage-y += common_init.c
 romstage-$(CONFIG_UDELAY_LAPIC) += fsb.c
 ramstage-$(CONFIG_UDELAY_LAPIC) += fsb.c
 postcar-$(CONFIG_UDELAY_LAPIC) += fsb.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += fsb.c
+smm-y += fsb.c

src/cpu/intel/haswell/Makefile.inc

@@ -13,8 +13,8 @@ ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smmrelocate.c
 romstage-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += stage_cache.c
 postcar-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += stage_cache.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += tsc_freq.c
+smm-y += finalize.c
+smm-y += tsc_freq.c
 
 ifneq ($(CONFIG_TSC_MONOTONIC_TIMER),y)
 bootblock-y += monotonic_timer.c

src/cpu/intel/model_2065x/Makefile.inc

@@ -13,11 +13,11 @@ subdirs-y += ../common
 ramstage-y += tsc_freq.c
 romstage-y += tsc_freq.c
 postcar-y += tsc_freq.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += tsc_freq.c
+smm-y += tsc_freq.c
 
 ramstage-y += acpi.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c
+smm-y += finalize.c
 
 romstage-y += stage_cache.c
 ramstage-y += stage_cache.c

src/cpu/intel/model_206ax/Makefile.inc

@@ -15,14 +15,14 @@ ramstage-y += acpi.c
 
 ramstage-y += common.c
 romstage-y += common.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += common.c
+smm-y += common.c
 
 ramstage-y += tsc_freq.c
 romstage-y += tsc_freq.c
 postcar-y += tsc_freq.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += tsc_freq.c
+smm-y += tsc_freq.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c
+smm-y += finalize.c
 
 romstage-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += stage_cache.c
 postcar-$(CONFIG_CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) += stage_cache.c

src/cpu/x86/smm/Makefile.inc

@@ -36,13 +36,16 @@ $(call src-to-obj,ramstage,$(obj)/cpu/x86/smm/smm.manual): $(obj)/smm/smm
 	@printf "    OBJCOPY    $(subst $(obj)/,,$(@))\n"
 	cd $(dir $<); $(OBJCOPY_smm) -I binary $(notdir $<) $(target-objcopy) $(abspath $@)
 
+ifeq ($(CONFIG_HAVE_SMI_HANDLER),y)
+ramstage-srcs += $(obj)/cpu/x86/smm/smm.manual
+endif
+
 ifeq ($(CONFIG_SMM_TSEG),y)
 
 smmstub-y += smm_stub.S
 
 smm-y += smm_module_handler.c
 
-ramstage-srcs += $(obj)/cpu/x86/smm/smm.manual
 ramstage-srcs += $(obj)/cpu/x86/smm/smmstub.manual
 
 # SMM Stub Module. The stub is used as a trampoline for relocation and normal
@@ -82,10 +85,6 @@ $(obj)/smm/smm: $(obj)/smm/smm.o $(src)/cpu/x86/smm/smm.ld
 	$(NM_smm) -n $(obj)/smm/smm.elf | sort > $(obj)/smm/smm.map
 	$(OBJCOPY_smm) -O binary $(obj)/smm/smm.elf $@
 
-ifeq ($(CONFIG_HAVE_SMI_HANDLER),y)
-ramstage-srcs += $(obj)/cpu/x86/smm/smm.manual
-endif
-
 smm-y += smmhandler.S
 smm-y += smihandler.c
 

src/cpu/x86/tsc/Makefile.inc

@@ -3,6 +3,4 @@ ramstage-$(CONFIG_UDELAY_TSC) += delay_tsc.c
 romstage-$(CONFIG_TSC_CONSTANT_RATE) += delay_tsc.c
 verstage-$(CONFIG_TSC_CONSTANT_RATE) += delay_tsc.c
 postcar-$(CONFIG_TSC_CONSTANT_RATE) += delay_tsc.c
-ifeq ($(CONFIG_HAVE_SMI_HANDLER),y)
 smm-$(CONFIG_TSC_CONSTANT_RATE) += delay_tsc.c
-endif

src/ec/acpi/Makefile.inc

@@ -2,6 +2,6 @@ ifeq ($(CONFIG_EC_ACPI),y)
 
 ramstage-y += ec.c
 romstage-y += ec.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += ec.c
+smm-y += ec.c
 
 endif

src/ec/lenovo/pmh7/Makefile.inc

@@ -1,7 +1,7 @@
 ifeq ($(CONFIG_EC_LENOVO_PMH7),y)
 
 ramstage-y += pmh7.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += pmh7.c
+smm-y += pmh7.c
 romstage-y += pmh7.c
 
 endif

src/mainboard/google/auron/Makefile.inc

@@ -19,7 +19,7 @@ romstage-$(CONFIG_CHROMEOS) += chromeos.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
 bootblock-$(CONFIG_CHROMEOS) += chromeos.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 romstage-y += variants/$(VARIANT_DIR)/pei_data.c
 ramstage-y += variants/$(VARIANT_DIR)/pei_data.c

src/mainboard/google/beltino/Makefile.inc

@@ -18,7 +18,7 @@ ramstage-$(CONFIG_CHROMEOS) += chromeos.c
 verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += chromeos.c
 ramstage-y += lan.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c variants/$(VARIANT_DIR)/led.c
+smm-y += smihandler.c variants/$(VARIANT_DIR)/led.c
 
 romstage-y += variants/$(VARIANT_DIR)/led.c
 

src/mainboard/google/butterfly/Makefile.inc

@@ -19,6 +19,6 @@ romstage-y += chromeos.c
 ramstage-y += chromeos.c
 romstage-y += gpio.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
+smm-y += mainboard_smi.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/google/cyan/Makefile.inc

@@ -24,7 +24,7 @@ ramstage-y += ec.c
 ramstage-y += irqroute.c
 ramstage-y += w25q64.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/$(VARIANT_DIR)
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/dragonegg/Makefile.inc

@@ -26,7 +26,7 @@ ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 ramstage-y += mainboard.c
 ramstage-y += ramstage.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/eve/Makefile.inc

@@ -26,4 +26,4 @@ ramstage-y += mainboard.c
 ramstage-y += ramstage.c
 ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c

src/mainboard/google/fizz/Makefile.inc

@@ -25,7 +25,7 @@ ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 ramstage-y += mainboard.c
 ramstage-y += ramstage.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/fizz/variants/karma/Makefile.inc

@@ -3,4 +3,4 @@ bootblock-y += gpio.c
 ramstage-y += gpio.c
 ramstage-y += nhlt.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c

src/mainboard/google/glados/Makefile.inc

@@ -29,7 +29,7 @@ ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 ramstage-y += mainboard.c
 ramstage-y += ramstage.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/$(VARIANT_DIR)
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/glados/variants/caroline/Makefile.inc

@@ -16,7 +16,7 @@
 
 romstage-y += variant.c
 ramstage-y += variant.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += variant.c
+smm-y += variant.c
 
 SPD_BIN = $(obj)/spd.bin
 

src/mainboard/google/glados/variants/cave/Makefile.inc

@@ -16,7 +16,7 @@
 
 romstage-y += variant.c
 ramstage-y += variant.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += variant.c
+smm-y += variant.c
 
 SPD_BIN = $(obj)/spd.bin
 

src/mainboard/google/glados/variants/chell/Makefile.inc

@@ -16,7 +16,7 @@
 
 romstage-y += variant.c
 ramstage-y += variant.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += variant.c
+smm-y += variant.c
 
 SPD_BIN = $(obj)/spd.bin
 

src/mainboard/google/glados/variants/glados/Makefile.inc

@@ -16,7 +16,7 @@
 
 romstage-y += variant.c
 ramstage-y += variant.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += variant.c
+smm-y += variant.c
 
 SPD_BIN = $(obj)/spd.bin
 

src/mainboard/google/hatch/Makefile.inc

@@ -24,7 +24,7 @@ romstage-y += romstage.c
 romstage-$(CONFIG_CHROMEOS) += chromeos.c
 
 verstage-$(CONFIG_CHROMEOS) += chromeos.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/jecht/Makefile.inc

@@ -19,7 +19,7 @@ ramstage-$(CONFIG_CHROMEOS) += chromeos.c
 verstage-$(CONFIG_CHROMEOS) += chromeos.c
 ramstage-y += lan.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c led.c
+smm-y += smihandler.c led.c
 
 romstage-y += variants/$(VARIANT_DIR)/pei_data.c
 ramstage-y += variants/$(VARIANT_DIR)/pei_data.c

src/mainboard/google/kahlee/Makefile.inc

@@ -29,7 +29,7 @@ ramstage-y += OemCustomize.c
 verstage-y += chromeos.c
 verstage-y += ec.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/link/Makefile.inc

@@ -19,7 +19,7 @@ romstage-y += chromeos.c
 ramstage-y += chromeos.c
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
+smm-y += mainboard_smi.c
 SPD_BIN = $(obj)/spd.bin
 
 # Order of names in SPD_SOURCES is important!

src/mainboard/google/octopus/Makefile.inc

@@ -8,7 +8,7 @@ ramstage-y += ec.c
 ramstage-y += mainboard.c
 
 verstage-$(CONFIG_CHROMEOS) += chromeos.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/poppy/Makefile.inc

@@ -25,7 +25,7 @@ ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 ramstage-y += mainboard.c
 ramstage-y += ramstage.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 smm-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 
 subdirs-y += variants/baseboard

src/mainboard/google/poppy/variants/nami/Makefile.inc

@@ -35,7 +35,7 @@ ramstage-y += gpio.c
 ramstage-y += nhlt.c
 ramstage-y += mainboard.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 # Add OEM ID table
 cbfs-files-y += oem.bin

src/mainboard/google/poppy/variants/nautilus/Makefile.inc

@@ -14,5 +14,5 @@ ramstage-y += nhlt.c
 ramstage-y += mainboard.c
 ramstage-y += sku.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += sku.c
+smm-y += smihandler.c
+smm-y += sku.c

src/mainboard/google/poppy/variants/nocturne/Makefile.inc

@@ -22,4 +22,4 @@ ramstage-y += nhlt.c
 ramstage-y += mainboard.c
 ramstage-y += ec.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += ec.c
+smm-y += ec.c

src/mainboard/google/rambi/Makefile.inc

@@ -19,7 +19,7 @@ ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 ramstage-y += irqroute.c
 ramstage-y += w25q64.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
+smm-y += mainboard_smi.c
 
 ramstage-y += variants/$(VARIANT_DIR)/gpio.c
 

src/mainboard/google/reef/Makefile.inc

@@ -8,7 +8,7 @@ ramstage-y += ec.c
 ramstage-y += mainboard.c
 
 verstage-$(CONFIG_CHROMEOS) += chromeos.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/google/sarien/Makefile.inc

@@ -20,7 +20,7 @@ ramstage-y += sku.c
 
 romstage-y += romstage.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 bootblock-$(CONFIG_CHROMEOS) += chromeos.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c

src/mainboard/google/slippy/Makefile.inc

@@ -18,7 +18,7 @@ ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 romstage-$(CONFIG_CHROMEOS) += chromeos.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 romstage-y += variants/$(VARIANT_DIR)/romstage.c
 

src/mainboard/google/stout/Makefile.inc

@@ -18,8 +18,8 @@ ramstage-y += ec.c
 romstage-y += chromeos.c
 ramstage-y += chromeos.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += ec.c
+smm-y += mainboard_smi.c
+smm-y += ec.c
 
 SRC_ROOT = $(src)/mainboard/google/stout
 romstage-y += gpio.c

src/mainboard/hp/pavilion_m6_1035dx/Makefile.inc

@@ -22,4 +22,4 @@ ramstage-y += BiosCallOuts.c
 ramstage-y += OemCustomize.c
 ramstage-y += ec.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
+smm-y += mainboard_smi.c

src/mainboard/intel/baskingridge/Makefile.inc

@@ -17,4 +17,4 @@ romstage-y += chromeos.c
 ramstage-y += chromeos.c
 verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += chromeos.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
+smm-y += mainboard_smi.c

src/mainboard/intel/cannonlake_rvp/Makefile.inc

@@ -27,7 +27,7 @@ romstage-y += romstage_fsp_params.c
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
 ramstage-y += mainboard.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
 

src/mainboard/intel/dcp847ske/Makefile.inc

@@ -1,4 +1,4 @@
 romstage-y += early_southbridge.c
 romstage-y += gpio.c
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c

src/mainboard/intel/glkrvp/Makefile.inc

@@ -10,7 +10,7 @@ ramstage-y += ec.c
 ramstage-y += mainboard.c
 
 verstage-$(CONFIG_CHROMEOS) += chromeos.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

src/mainboard/intel/kblrvp/Makefile.inc

@@ -33,7 +33,7 @@ ramstage-y += ramstage.c
 
 ramstage-y += hda_verb.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 subdirs-y += variants/$(VARIANT_DIR)
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include

src/mainboard/intel/kunimitsu/Makefile.inc

@@ -28,7 +28,7 @@ ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
 ramstage-y += mainboard.c
 ramstage-y += ramstage.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 ifeq ($(CONFIG_PLATFORM_USES_FSP2_0),y)
 romstage-srcs := $(subst $(MAINBOARDDIR)/romstage.c,$(MAINBOARDDIR)/romstage_fsp20.c,$(romstage-srcs))

src/mainboard/intel/strago/Makefile.inc

@@ -25,4 +25,4 @@ ramstage-y += irqroute.c
 ramstage-y += ramstage.c
 ramstage-y += w25q64.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c

src/mainboard/lenovo/g505s/Makefile.inc

@@ -22,4 +22,4 @@ ramstage-y += BiosCallOuts.c
 ramstage-y += OemCustomize.c
 ramstage-y += ec.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += mainboard_smi.c
+smm-y += mainboard_smi.c

src/mainboard/lenovo/l520/Makefile.inc

@@ -15,6 +15,6 @@
 
 romstage-y += romstage.c
 romstage-y += gpio.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/s230u/Makefile.inc

@@ -1,6 +1,6 @@
 romstage-y += gpio.c
 ramstage-y += ec.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 # FIXME: SPD images for samsung_8gb and hynix_8gb are missing.
 # It's possible that no mainboards with that variation were manufactured.

src/mainboard/lenovo/t420/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += gpio.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/t420s/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += gpio.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/t430/Makefile.inc

@@ -1,5 +1,5 @@
 romstage-y += romstage.c
 romstage-y += gpio.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/t430s/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += variants/$(VARIANT_DIR)/gpio.c
 romstage-y += variants/$(VARIANT_DIR)/romstage.c
 ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c

src/mainboard/lenovo/t520/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += variants/$(VARIANT_DIR)/gpio.c
 romstage-y += variants/$(VARIANT_DIR)/romstage.c
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/t530/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += variants/$(VARIANT_DIR)/gpio.c
 romstage-y += variants/$(VARIANT_DIR)/romstage.c
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/t60/Makefile.inc

@@ -13,6 +13,6 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += dock.c
+smm-y += dock.c
 romstage-y += dock.c
 romstage-y += gpio.c

src/mainboard/lenovo/x1_carbon_gen1/Makefile.inc

@@ -15,7 +15,7 @@
 
 subdirs-y += spd
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += gpio.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/x201/Makefile.inc

@@ -13,8 +13,8 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += dock.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += dock.c
+smm-y += smihandler.c
 romstage-y += dock.c
 ramstage-y += dock.c
 romstage-y += gpio.c

src/mainboard/lenovo/x220/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += variants/$(VARIANT_DIR)/gpio.c
 romstage-y += variants/$(VARIANT_DIR)/romstage.c
 

src/mainboard/lenovo/x230/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 romstage-y += gpio.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/lenovo/x60/Makefile.inc

@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += dock.c
+smm-y += dock.c
 romstage-y += dock.c
 ramstage-y += dock.c
 romstage-y += gpio.c

src/mainboard/lenovo/z61t/Makefile.inc

@@ -13,6 +13,6 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += dock.c
+smm-y += dock.c
 romstage-y += dock.c
 romstage-y += gpio.c

src/mainboard/packardbell/ms2290/Makefile.inc

@@ -13,6 +13,6 @@
 ## GNU General Public License for more details.
 ##
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads

src/mainboard/scaleway/tagada/Makefile.inc

@@ -26,6 +26,6 @@ bootblock-y += bmcinfo.c
 postcar-y += bmcinfo.c
 romstage-y += bmcinfo.c
 ramstage-y += bmcinfo.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += bmcinfo.c
+smm-y += bmcinfo.c
 
 CPPFLAGS_common += -Isrc/mainboard/$(MAINBOARDDIR)/

src/northbridge/intel/fsp_rangeley/Makefile.inc

@@ -27,7 +27,7 @@ romstage-y += raminit.c
 romstage-y += ../../../arch/x86/walkcbfs.S
 romstage-y += port_access.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += udelay.c
+smm-y += udelay.c
 
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)
 

src/northbridge/intel/gm45/Makefile.inc

@@ -35,7 +35,7 @@ ramstage-y += ram_calc.c
 ramstage-y += northbridge.c
 ramstage-y += gma.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/lapic/apic_timer.c
+smm-y += ../../../cpu/x86/lapic/apic_timer.c
 
 postcar-y += ram_calc.c
 

src/northbridge/intel/haswell/Makefile.inc

@@ -29,7 +29,7 @@ romstage-y += raminit.c
 romstage-y += early_init.c
 romstage-y += report_platform.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c
+smm-y += finalize.c
 
 # We don't ship that, but booting without it is bound to fail
 cbfs-files-$(CONFIG_HAVE_MRC) += mrc.bin

src/northbridge/intel/nehalem/Makefile.inc

@@ -27,7 +27,7 @@ romstage-y += raminit.c
 romstage-y += early_init.c
 romstage-y += ../../../arch/x86/walkcbfs.S
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c
+smm-y += finalize.c
 
 postcar-y += ram_calc.c
 

src/northbridge/intel/sandybridge/Makefile.inc

@@ -26,7 +26,7 @@ romstage-y += ram_calc.c
 
 ramstage-y += common.c
 romstage-y += common.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += common.c
+smm-y += common.c
 
 ifeq ($(CONFIG_USE_NATIVE_RAMINIT),y)
 romstage-y += early_dmi.c
@@ -46,7 +46,7 @@ romstage-y += romstage.c
 romstage-y += early_init.c
 romstage-y += ../../../arch/x86/walkcbfs.S
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c
+smm-y += finalize.c
 
 postcar-y += ram_calc.c
 

src/soc/intel/denverton_ns/Makefile.inc

@@ -71,10 +71,10 @@ ramstage-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c
 ramstage-$(CONFIG_DISPLAY_UPD_DATA) += upd_display.c
 ramstage-$(CONFIG_DISPLAY_HOBS) += hob_display.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += soc_util.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += tsc_freq.c
+smm-y += pmutil.c
+smm-y += soc_util.c
+smm-y += smihandler.c
+smm-y += tsc_freq.c
 smm-$(CONFIG_SPI_FLASH_SMM) += spi.c
 smm-$(CONFIG_DRIVERS_UART_8250MEM) += uart_debug.c
 

src/soc/intel/fsp_baytrail/Makefile.inc

@@ -33,10 +33,10 @@ romstage-y += memmap.c
 ramstage-y += tsc_freq.c
 romstage-y += tsc_freq.c
 postcar-y += tsc_freq.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += tsc_freq.c
+smm-y += tsc_freq.c
 ramstage-y += spi.c
 romstage-y += spi.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += spi.c
+smm-y += spi.c
 ramstage-y += chip.c
 ramstage-y += iosf.c
 romstage-y += iosf.c
@@ -51,8 +51,8 @@ ramstage-y += cpu.c
 ramstage-y += acpi.c
 ramstage-y += lpe.c
 ramstage-y += lpss.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += pmutil.c
+smm-y += smihandler.c
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smm.c
 
 ramstage-y += placeholders.c

src/soc/intel/fsp_broadwell_de/Makefile.inc

@@ -31,9 +31,9 @@ ramstage-y += iou_complto.c
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smmrelocate.c
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c
 ramstage-y += vtd.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += tsc_freq.c
+smm-y += pmutil.c
+smm-y += smihandler.c
+smm-y += tsc_freq.c
 
 CPPFLAGS_common += -I$(src)/soc/intel/fsp_broadwell_de/include
 CPPFLAGS_common += -I$(src)/soc/intel/fsp_broadwell_de/fsp

src/southbridge/amd/agesa/hudson/Makefile.inc

@@ -31,7 +31,7 @@ postcar-y += ramtop.c
 romstage-y += imc.c
 ramstage-y += imc.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c smi_util.c
+smm-y += smihandler.c smi_util.c
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c smi_util.c
 
 # ROMSIG At ROMBASE + 0x20000:

src/southbridge/amd/pi/hudson/Makefile.inc

@@ -60,8 +60,8 @@ ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c
 ramstage-$(CONFIG_HUDSON_UART) += uart.c
 ramstage-y += usb.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smi_util.c
+smm-y += smihandler.c
+smm-y += smi_util.c
 
 # ROMSIG At ROMBASE + 0x20000:
 # +-----------+---------------+----------------+------------+

src/southbridge/intel/bd82x6x/Makefile.inc

@@ -34,7 +34,7 @@ ramstage-y += me_status.c
 
 ramstage-$(CONFIG_ELOG) += elog.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c me.c me_8.x.c pch.c
+smm-y += smihandler.c me.c me_8.x.c pch.c
 
 romstage-y += early_smbus.c me_status.c
 romstage-y += early_rcba.c

src/southbridge/intel/i82801dx/Makefile.inc

@@ -26,7 +26,7 @@ ramstage-y += usb2.c
 
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 romstage-y += early_smbus.c
 

src/southbridge/intel/i82801gx/Makefile.inc

@@ -32,7 +32,7 @@ ramstage-y += usb_ehci.c
 
 ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 romstage-y += early_smbus.c
 

src/southbridge/intel/i82801ix/Makefile.inc

@@ -33,7 +33,7 @@ ifneq ($(CONFIG_SMM_TSEG),y)
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S
 endif
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 romstage-y += early_init.c
 romstage-y += early_smbus.c

src/southbridge/intel/i82801jx/Makefile.inc

@@ -29,7 +29,7 @@ ramstage-y += ../common/pciehp.c
 
 ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c
 
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+smm-y += smihandler.c
 
 romstage-y += early_smbus.c
 

src/southbridge/intel/lynxpoint/Makefile.inc

@@ -42,8 +42,8 @@ ramstage-y += acpi.c
 ramstage-$(CONFIG_ELOG) += elog.c
 
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c pmutil.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c me_9.x.c pch.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += pmutil.c usb_ehci.c usb_xhci.c
+smm-y += smihandler.c me_9.x.c pch.c
+smm-y += pmutil.c usb_ehci.c usb_xhci.c
 
 bootblock-y += early_pch.c
 romstage-y += early_usb.c early_smbus.c early_me.c me_status.c early_pch.c
@@ -52,7 +52,7 @@ romstage-y += rcba.c pmutil.c
 ifeq ($(CONFIG_INTEL_LYNXPOINT_LP),y)
 romstage-y += lp_gpio.c
 ramstage-y += lp_gpio.c
-smm-$(CONFIG_HAVE_SMI_HANDLER) += lp_gpio.c
+smm-y += lp_gpio.c
 endif
 
 verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += pmutil.c