Fix 2 infinite loops if IMC doesn't respond
ACPI code: The ACPI code is not currently being compiled in by default, but assuming that it will be at some point, I'm fixing the loop that waits for the IMC to respond after sending it a command. The loop now exits after 500ms, similar to the function in agesa. Agesa Code: a 16 bit variable will always be less than 100000. Change to be a 32 bit variable. Change-Id: I9430ef900a22d056871b744f3b1511abdfea516e Signed-off-by: Martin Roth <martin@se-eng.com> Reviewed-on: http://review.coreboot.org/2119 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick@georgi-clan.de> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
parent
238780c8da
commit
92dd172a57
|
@ -18,9 +18,11 @@ IndexField(IMCX, IMCA, ByteAcc, NoLock, Preserve) {
|
||||||
Method(WACK, 0)
|
Method(WACK, 0)
|
||||||
{
|
{
|
||||||
Store(0, Local0)
|
Store(0, Local0)
|
||||||
While (LNotEqual(Local0, 0xFA)) {
|
Store(50, Local1)
|
||||||
|
While (LAnd (LNotEqual(Local0, 0xFA), LGreater(Local1,0))) {
|
||||||
Store(MRG0, Local0)
|
Store(MRG0, Local0)
|
||||||
Sleep(10)
|
Sleep(10)
|
||||||
|
Decrement(Local1)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -18,9 +18,11 @@ IndexField(IMCX, IMCA, ByteAcc, NoLock, Preserve) {
|
||||||
Method(WACK, 0)
|
Method(WACK, 0)
|
||||||
{
|
{
|
||||||
Store(0, Local0)
|
Store(0, Local0)
|
||||||
While (LNotEqual(Local0, 0xFA)) {
|
Store(50, Local1)
|
||||||
|
While (LAnd (LNotEqual(Local0, 0xFA), LGreater(Local1,0))) {
|
||||||
Store(MRG0, Local0)
|
Store(MRG0, Local0)
|
||||||
Sleep(10)
|
Sleep(10)
|
||||||
|
Decrement(Local1)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -126,7 +126,7 @@ WaitForEcLDN9MailboxCmdAck (
|
||||||
)
|
)
|
||||||
{
|
{
|
||||||
UINT8 Msgdata;
|
UINT8 Msgdata;
|
||||||
UINT16 Delaytime;
|
UINT32 Delaytime;
|
||||||
|
|
||||||
Msgdata = 0;
|
Msgdata = 0;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue