From 92dde2fdd7516a026991116b7466f968e702828c Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Fri, 7 Apr 2017 02:03:45 -0700 Subject: [PATCH] google/eve: Update I2C bus timing Update the I2C rise/fall timings based on newly measured values on a new board with updated pull-up resistor values. Touchscreen: rise time 98ns, fall time 38ms Touchpad: rise time 111ns, fall time 41ns TPM: rise time 112ns, fall time 34ns BUG=b:35583133 BRANCH=none TEST=Each I2C bus frequency was verified on a scope to be ~400MHz Change-Id: Ibb3a15fa0cc862f36c1b9c63ac7847221020c4c0 Signed-off-by: Duncan Laurie Reviewed-on: https://review.coreboot.org/19202 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh --- src/mainboard/google/eve/devicetree.cb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index d8f6362829..427ba6b916 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -163,7 +163,7 @@ chip soc/intel/skylake register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3" register "i2c[0]" = "{ .speed = I2C_SPEED_FAST_PLUS, - .rise_time_ns = 17, + .rise_time_ns = 98, .fall_time_ns = 38, }" @@ -172,16 +172,16 @@ chip soc/intel/skylake register "i2c[1]" = "{ .early_init = 1, .speed = I2C_SPEED_FAST, - .rise_time_ns = 88, - .fall_time_ns = 32, + .rise_time_ns = 112, + .fall_time_ns = 34, }" # Touchpad register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8" register "i2c[2]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 247, - .fall_time_ns = 17, + .rise_time_ns = 111, + .fall_time_ns = 41, }" # Audio