GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/dram: Inline value into print statement 

By default printram() expands to nothing in normal builds, and so
scan-build thinks that the assignment to reg8 is unused. Inline the
value of reg8 into the print statement to silence the warning.

Change-Id: I921fe08949c4135367bee9646b3b365097fab19e
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: scan-build 8.0.0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33744
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Jacob Garber 2019-06-24 13:02:27 -06:00 committed by Martin Roth
parent 70f6d82614
commit 93064ff7cd
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/device/dram/ddr3.c
View File

@ -382,8 +382,7 @@ int spd_decode_ddr3(dimm_attr * dimm, spd_raw_data spd)
dimm->flags.therm_sensor ? "yes" : "no"); dimm->flags.therm_sensor ? "yes" : "no");
/* SDRAM Device Type */ /* SDRAM Device Type */
reg8 = spd[33]; printram(" Standard SDRAM : %s\n", (spd[33] & 0x80) ? "no" : "yes");
printram(" Standard SDRAM : %s\n", (reg8 & 0x80) ? "no" : "yes");
if (spd[63] & 0x01) { if (spd[63] & 0x01) {
dimm->flags.pins_mirrored = 1; dimm->flags.pins_mirrored = 1;