From 9314bb6f0a991593b5fb9a6a6cced5aad02e6587 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 15 Dec 2023 11:15:26 +0100 Subject: [PATCH] vc/amd/opensil: add _POC suffix to SOC_AMD_OPENSIL_GENOA The openSIL code for the Genoa SoC is only a proof of concept, so change the name of the Kconfig option to include this code in the build from SOC_AMD_OPENSIL_GENOA to SOC_AMD_OPENSIL_GENOA_POC to clarify that this is code that isn't intended or ready to be productized. Signed-off-by: Felix Held Change-Id: If91cdaa7c324426964bba2de2109b6c38482fab8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79574 Reviewed-by: Varshit Pandya Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- src/soc/amd/genoa_poc/Kconfig | 2 +- src/vendorcode/amd/opensil/Kconfig | 7 ++++--- src/vendorcode/amd/opensil/Makefile.inc | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/soc/amd/genoa_poc/Kconfig b/src/soc/amd/genoa_poc/Kconfig index 782e4aa726..3560e6076e 100644 --- a/src/soc/amd/genoa_poc/Kconfig +++ b/src/soc/amd/genoa_poc/Kconfig @@ -43,7 +43,7 @@ config SOC_SPECIFIC_OPTIONS select SOC_AMD_COMMON_BLOCK_UCODE select SOC_AMD_COMMON_BLOCK_USE_ESPI select SOC_AMD_OPENSIL - select SOC_AMD_OPENSIL_GENOA + select SOC_AMD_OPENSIL_GENOA_POC select X86_CUSTOM_BOOTMEDIA config USE_EXP_X86_64_SUPPORT diff --git a/src/vendorcode/amd/opensil/Kconfig b/src/vendorcode/amd/opensil/Kconfig index 0d8420bb2a..bc80b8c825 100644 --- a/src/vendorcode/amd/opensil/Kconfig +++ b/src/vendorcode/amd/opensil/Kconfig @@ -2,14 +2,15 @@ if SOC_AMD_OPENSIL -config SOC_AMD_OPENSIL_GENOA +config SOC_AMD_OPENSIL_GENOA_POC bool help - Select this on SoCs that use the Genoa version of openSIL. + Select this on SoCs that use the Genoa proof of concept version of + openSIL. config AMD_OPENSIL_PATH string - default "$(top)/src/vendorcode/amd/opensil/genoa_poc/opensil" if SOC_AMD_OPENSIL_GENOA + default "$(top)/src/vendorcode/amd/opensil/genoa_poc/opensil" if SOC_AMD_OPENSIL_GENOA_POC help Set to the path of the openSIL directory containing meson.build. example diff --git a/src/vendorcode/amd/opensil/Makefile.inc b/src/vendorcode/amd/opensil/Makefile.inc index ca206aa9bf..a97bf63e7c 100644 --- a/src/vendorcode/amd/opensil/Makefile.inc +++ b/src/vendorcode/amd/opensil/Makefile.inc @@ -8,7 +8,7 @@ endif opensil_dir := $(call strip_quotes,$(CONFIG_AMD_OPENSIL_PATH)) -subdirs-$(CONFIG_SOC_AMD_OPENSIL_GENOA) += genoa_poc +subdirs-$(CONFIG_SOC_AMD_OPENSIL_GENOA_POC) += genoa_poc ifeq ($(CONFIG_ARCH_RAMSTAGE_X86_32),y) cpu_family_string="x86"