From 93a9630be388e642abad00e4a90f508bf7446741 Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Mon, 15 Jun 2015 12:36:53 -0700 Subject: [PATCH] buildgcc: Clarify required user action When required tools are missing, try to give the user more detailed information on how to solve the problem. Change-Id: Ifa21c1af38a036a7d4f5a786041a87a7d45f4ec5 Signed-off-by: Stefan Reinauer Reviewed-on: http://review.coreboot.org/10555 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/crossgcc/buildgcc | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 552a6a2002..0c6193d517 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -107,6 +107,18 @@ normalize_dirs() perl -pi -e "s,/lib64,/lib," $DESTDIR$TARGETDIR/lib/*.la } +please_install() +{ + test -r /etc/os-release && source /etc/os-release + case "$ID_LIKE" in + debian) solution="sudo apt-get install $1" ;; + suse) solution="sudo zypper install $1" ;; + *) solution="using your OS packaging system" ;; + esac + + printf "${RED}ERROR:${red} Missing tool: Please install \'$1\' utility. (eg $solution)${NC}\n" >&2 +} + searchtool() { # $1 short name @@ -157,7 +169,7 @@ searchtool() fi fi fi - printf "${RED}ERROR:${red} Missing tool: Please install $1 (eg using your OS packaging system)${NC}\n" >&2 + please_install $1 [ -z "$3" ] && exit 1 false }