From 9405dd066e71c8b529610e90ceff5c3f2a645818 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 8 Nov 2022 21:14:34 +0100 Subject: [PATCH] drivers/intel/fsp2_0/hand_off_block: remove unneeded line breaks Since the characters per line limit was increased from 80 to 96, some line breaks can be removed to improve code readability. Signed-off-by: Felix Held Change-Id: I92aa3fec8c8caba143e418efc999ec4a7c5d93c4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69461 Reviewed-by: Raul Rangel Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/drivers/intel/fsp2_0/hand_off_block.c | 24 ++++++++--------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index a40da7736c..21ce03e875 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -132,8 +132,7 @@ struct hob_resource *find_resource_hob_by_guid(const struct hob_header *hob, { const struct hob_resource *res; - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; - hob = fsp_next_hob(hob)) { + for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) continue; @@ -195,8 +194,7 @@ const void *fsp_find_extension_hob_by_guid(const uint8_t *guid, size_t *size) if (!hob) return NULL; - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; - hob = fsp_next_hob(hob)) { + for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { if (hob->type != HOB_TYPE_GUID_EXTENSION) continue; @@ -219,12 +217,10 @@ static void display_fsp_version_info_hob(const void *hob) uint8_t vs; #if CONFIG(DISPLAY_FSP_VERSION_INFO) const FIRMWARE_VERSION_INFO *fvi; - const FIRMWARE_VERSION_INFO_HOB *fvih = - (FIRMWARE_VERSION_INFO_HOB *)hob; + const FIRMWARE_VERSION_INFO_HOB *fvih = (FIRMWARE_VERSION_INFO_HOB *)hob; fvi = (void *)&fvih[1]; - str_ptr = (char *)((uintptr_t)fvi + - (fvih->Count * sizeof(FIRMWARE_VERSION_INFO))); + str_ptr = (char *)((uintptr_t)fvi + (fvih->Count * sizeof(FIRMWARE_VERSION_INFO))); tcount = fvih->Count; #elif CONFIG(DISPLAY_FSP_VERSION_INFO_2) @@ -255,8 +251,7 @@ static void display_fsp_version_info_hob(const void *hob) fvi[index].Version.Revision == 0xFF && fvi[index].Version.BuildNumber == 0xFF && vs == 0) { - str_ptr = (char *)((uintptr_t)str_ptr + cnt + - sizeof(uint8_t)); + str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t)); continue; } /* @@ -274,13 +269,11 @@ static void display_fsp_version_info_hob(const void *hob) fvi[index].Version.Revision, fvi[index].Version.BuildNumber); else { - str_ptr = (char *)((uintptr_t)str_ptr + cnt + - sizeof(uint8_t)); + str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t)); cnt = strlen(str_ptr); printk(BIOS_DEBUG, "%s\n", str_ptr); } - str_ptr = (char *)((uintptr_t)str_ptr + cnt + - sizeof(uint8_t)); + str_ptr = (char *)((uintptr_t)str_ptr + cnt + sizeof(uint8_t)); } #endif } @@ -294,8 +287,7 @@ void fsp_display_fvi_version_hob(void) return; printk(BIOS_DEBUG, "Display FSP Version Info HOB\n"); - for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; - hob = fsp_next_hob(hob)) { + for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { if (hob->type != HOB_TYPE_GUID_EXTENSION) continue;