GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not try to display non-printable characters on the bootlog and 

ramdump screens. This fixes unaligned display on serial console.

The current isprint() implementation assumes a C locale, so also
characters with the eigth bit set are supressed (they produced  
inconsistant results on VGA and serial anyway).

Signed-off-by: Ulf Jordan <jordan@chalmers.se>
Acked-by: Peter Stuge <peter@stuge.se>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3621 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Ulf Jordan 2008-09-30 06:13:54 +00:00 committed by Peter Stuge
parent 45db366d5c
commit 94c1bd8904
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
payloads/coreinfo/bootlog_module.c
View File

@ -63,7 +63,7 @@ static int bootlog_module_redraw(WINDOW *win)
/* FIXME: Handle lines longer than 80 characters. */ /* FIXME: Handle lines longer than 80 characters. */
while (y <= 18) { while (y <= 18) {
mvwaddnstr(win, y + 2, x, tmp, 1); mvwaddch(win, y + 2, x, isprint(*tmp) ? *tmp : ' ');
x++; x++;
tmp++; tmp++;
if (*tmp == '\n') { if (*tmp == '\n') {

3
payloads/coreinfo/ramdump_module.c
View File

@ -44,7 +44,8 @@ static void dump_ram(WINDOW *win, uint32_t addr, int row, int col)
mvwaddch(win, row + y, col + 76, '|'); mvwaddch(win, row + y, col + 76, '|');
} }
mvwprintw(win, row + y, col + x + 9, "%02x", ptr[i - 1]); mvwprintw(win, row + y, col + x + 9, "%02x", ptr[i - 1]);
mvwprintw(win, row + y, 62 + count++, "%c", ptr[i - 1]); mvwprintw(win, row + y, 62 + count++, "%c",
isprint(ptr[i - 1]) ? ptr[i - 1] : ' ');
x += 3; x += 3;
if (x == 24) /* One more space after column/byte 8. */ if (x == 24) /* One more space after column/byte 8. */
x++; x++;